PHP List Users from SQL Database in Table

Question

Hi so im trying to put all of the useres in a database, table into a html table this is what i have:

<table class="table table-striped">
    <thead>
        <tr>
            <th>UUID</th>
            <th>Full Name</th>
            <th>Email</th>
            <th>Access Key</th>
            <th>Phone Number</th>
            <th>Activated</th>
            <th>Role</th>
        </tr>
    </thead>
    <tbody>

        <?php
        include_once('inc/conf/databaseConnect.php');
        $query = mysql_query("SELECT * FROM list_users ORDER by id");
        while($row = mysql_fetch_array($query)){
            echo "<tr>";
            echo "<td>".$row['uuid']."</td>";
            echo "<td>".$row['firstname'].$rowtwo['lastname']."</td>";
            echo "<td>".$row['email']."</td>";
            echo "<td>".$row['security_key']."</td>";
            echo "<td>".$row['phone_no']."</td>";
            echo "<td>".$row['activated']."</td>";
            echo "<td>".$row['role']."</td>";
            echo "</tr>";
        }
        ?>

    </tbody>
</table>

This dosnt return anything, or any errors. It connects to the database correctly ive checked that its just not retrieving the users.

Image of database structure

databaseConnect.php:

    <?php

//Create Connnection
$sqlLink = mysqli_connect('localhost', 'root', 'classified', 'user_details');

//If Error Connecting
if(!$sqlLink) {
    die('<center><br><h3>Error connecting to servers Database.');
}

?>

You don't actually check for errors. That may be why you don't see them. — John Conde, Oct 25 '15 at 15:29
apache logs the php errors to a file, and i chedk for errors in the db connect to make sure it connected properly and i use that dbconnect file for the login and edit details. — Joosh, Oct 25 '15 at 15:30
Does that query work on the db directly? Maybe the order by is incorrect and it should be `order by uuid`? — chris85, Oct 25 '15 at 15:31
ive added an image of the database structure. uuid is their username e.g. "Joosh17" — Joosh, Oct 25 '15 at 15:33
`databaseConnect.php` is what we'd like to know is in there. `mysql_`? `mysqli_`? PDO? — Funk Forty Niner, Oct 25 '15 at 15:35
I know that rowtwo part i noticed that when i posted it, and ive posted the databaseConnect.php code — Joosh, Oct 25 '15 at 15:41
Wow @Fred-ii- nice detecting. Josh, you need to use `mysqli` functions with a `mysqli` connection. `mysql_` functions are for a different, outdated/insecure, driver. — chris85, Oct 25 '15 at 15:42
Take a look at their manual there are all different ones you can use. http://php.net/manual/en/mysqli.query.php (i prefer the prepare and execute). Then you need to update your fetch as well. — chris85, Oct 25 '15 at 15:44
Great, you should accept Fred's answer in that case as he identified the issue. http://meta.stackexchange.com/questions/5234/how-does-accepting-an-answer-work — chris85, Oct 25 '15 at 15:51
@chris85 OP has quite a few questions/answers with none accepted. Maybe that will show them how to properly close a question ;-) *Cheers* — Funk Forty Niner, Oct 25 '15 at 16:00

score 2 · Answer 1 · edited May 23 '17 at 11:44

After seeing your edit because you did not originally show us which connection method you were using; the almighty answer here (least the most important one) is that you can't mix different MySQL APIs.

Can I mix MySQL APIs in PHP?

You need to use the same one from connection to query.

Plus that $rowtwo should be $row as I stated in comments along with my asking about what was inside your databaseConnect.php file.

Get to work with prepared statements also to help protect against an SQL injection.

https://en.wikipedia.org/wiki/Prepared_statement

score 1 · Accepted Answer · edited Oct 25 '15 at 15:51

Thanks. I have fixed the issue i updated to using mysqli's methods

<?php
include_once('inc/conf/databaseConnect.php');
$query = $sqlLink->query("SELECT * FROM list_users ORDER by id");
while($row = $query->fetch_array()){
    echo "<tr>";
    echo "<td>".$row['uuid']."</td>";
    echo "<td>".$row['firstname'].$row['lastname']."</td>";
    echo "<td>".$row['email']."</td>";
    echo "<td>".$row['security_key']."</td>";
    echo "<td>".$row['phone_no']."</td>";
    echo "<td>".$row['activated']."</td>";
    echo "<td>".$row['role']."</td>";
    echo "</tr>";
}
?>

score 0 · Answer 3 · answered Oct 25 '15 at 15:35

0

At least check for errors:

if ($query = mysql_query("SELECT * FROM list_users ORDER by id");) {
  ...
} else {
  echo '<b>MySQL error:</b><br>' . mysql_error() . '<br />';
}

answered Oct 25 '15 at 15:35

Alex

16,739
1
28
51

Its not using the databaseConnect.php file because access denied. – Joosh Oct 25 '15 at 15:38

score 0 · Answer 4 · edited Oct 25 '15 at 15:45

0

You must use mysql_fetch_assoc() instead of mysql_fetch_array or fetch like this mysql_fetch_array($result, MYSQL_ASSOC).

edited Oct 25 '15 at 15:45

chris85

23,846
7
34
51

answered Oct 25 '15 at 15:37

Nuriddin Rashidov

956
7
26

Why can't OP use `mysql_fetch_array`? This `mysql_fetch_array($query)` seems valid to me although gives back named and numerical references. – chris85 Oct 25 '15 at 15:40
yeah off course it's return both type but, sometime it's changed pointer in array. – Nuriddin Rashidov Oct 25 '15 at 15:44

PHP List Users from SQL Database in Table

4 Answers4

Linked