How to call a method from another method inside the object in ES6

Question

I have a object, and I need to call a method of it from another method inside the same object. I'm using ES6 syntax:

var user = {
login(name, password) {
        return new Promise(function(resolve, reject) {
            console.log('ready to find');
            var args = {
                'name': 'users',
                'query': {
                    'name': name
                },
                'options': {
                    '_id': 1,
                    'name': 1,
                    'password': 1
                }
            };
            db.find(args).toArray().then(function(result) {
                    var auth = {};
                    if(result[0] && result[0].password == password) {
                        console.log('user ok');
                        auth = {
                            ok: 1,
                            userID: result[0]._id,
                            user: result[0].name
                        };
                    } else {
                        console.log('user wrong');
                        auth = {
                            ok: -1,
                            errmsg: 'password wrong'
                        };
                    }
                    resolve(auth);
                })
                .catch(function(err) {
                    reject(err);
                });
        });
    },
    find(userID) {
        console.log("USER: find");
        return new Promise(function(resolve, reject) {
            var args = {
                'name': 'users',
                'query': {
                    '_id': userID
                },
                'options': {
                    'name': 1
                }
            };
            db.find(args).toArray().then(function(result) {
                    var findResult = {};
                    if(result[0]) {
                        findResult.ok = 1;
                        findResult.user = result[0].name;
                    } else {
                        findResult.ok = -1;
                        findResult.errmsg = 'not found';
                    }
                    return findResult;
                })
                .catch(function(err) {
                    throw err;
                });
        });
    },
    authenticate(session) {
        return new Promise(function(resolve, reject) {
            console.log("USER: authenticate");
            if(session.cookie && session.userID && session.user) {
                var _expires = session.cookie._expires;
                var userID = session.userID;
                var user = session.user;
                if(new Date(_expires) > new Date(Date.now())) {
                    console.log("USER: session isn't expired");
        console.log(userID);
                    user.find(userID);
                }
            }
        });
    },

};

I can call the user.find() outside, but can't call it from the user.anthenticate(). The console.log("USER: session isn't expired"); and console.log(userID); worked well, but the console.log("USER: find"); didn't

What are you expecting to happen? Is this example complete? `find` has no body. — sdgluck, Oct 31 '15 at 11:58
no, it's not complete. I want to call the find() method but it doesn't work. I can call it from the outside. — Brick Yang, Oct 31 '15 at 12:00
`args` is undefined, `find()` does nothing. If you would fix those two it would work — baao, Oct 31 '15 at 12:00
@baao nope. the args is fine, I can log it just before the `this.find(args)` — Brick Yang, Oct 31 '15 at 12:02
Then it would work... http://jsfiddle.net/m3czdwra/1/ ... If args is defined, your `name` parameter isn't used... — baao, Oct 31 '15 at 12:03
@baao alright, this sample works indeed. I edit the post and complete the code, would you help me to check what's the problem here? — Brick Yang, Oct 31 '15 at 12:13
Avoid the [`Promise` constructor antipattern](http://stackoverflow.com/q/23803743/1048572) — Bergi, Oct 31 '15 at 12:17

score 0 · Accepted Answer · answered Oct 31 '15 at 12:27

Your statement

var user = session.user;

introduces a second user variable that shadows the one with the find method. Just omit it, you don't need it.

var user = {
    login(name, password) {
        console.log('ready to find');
        return db.find({
            'name': 'users',
            'query': {'name': name},
            'options': {'_id': 1, 'name': 1, 'password': 1}
        }).toArray().then(function(result) {
            var auth = {};
            if(result[0] && result[0].password == password) {
                console.log('user ok');
                return {ok: 1, userID: result[0]._id, user: result[0].name};
            } else {
                console.log('user wrong');
                return {ok: -1, errmsg: 'password wrong'};
            }
        });
    },
    find(userID) {
        console.log("USER: find");
        db.find({
            'name': 'users',
            'query': {'_id': userID},
            'options': {'name': 1}
        }).toArray().then(function(result) {
            var findResult = {};
            if(result[0]) {
                return {ok: 1, user: result[0].name};
            } else {
                return {ok: -1, errmsg: 'not found'};
            }
        });
    },
    authenticate(session) {
        console.log("USER: authenticate");
        if(session.cookie && session.userID && session.user) {
            var _expires = session.cookie._expires;
            var userID = session.userID;
            if(new Date(_expires) > new Date(Date.now())) {
                console.log("USER: session isn't expired");
                console.log(userID);
                return user.find(userID);
            }
        }
    });
}

How to call a method from another method inside the object in ES6

1 Answers1