Difficulties adding onclick to a link with javascript

Question

I have a script that makes that makes a tile for every item in an XML-file. The tile is a div inside an "a" tag created by javascript.

document.getElementById('Body').appendChild(tileLink);
tileLink.appendChild(tile);
tile.appendChild(tileTitle);
tile.appendChild(tileImg);
document.write(" ");

So when tileLink is clicked a javascript function "showDiv(divId)" has to be loaded. divId is a variable in the script needed to load the function. I've tried these 2 lines but with both the script doesn't work and no objects are loaded.

tileLink.onclick = showDiv(divId);
textLink.addEventListener("click", showDiv(divId));

Where am I wrong?

Note the 2nd half of the accepted answer on the duplicate. If anyone has a better close candidate do let me know (there must be one) so I can favorite it and use it instead in the future. — James Montagne, Nov 05 '15 at 20:51

score 3 · Answer 1 · answered Nov 05 '15 at 20:47

3

Event handlers require function references. By invoking the function, you are immediately executing it.

textLink.addEventListener("click", function() {
    showDiv(divId);
});

answered Nov 05 '15 at 20:47

Sterling Archer

22,070
18
81
118

Doesn't work either... – Michael Tytgat Nov 05 '15 at 20:54
If I do this, only the last item is shown – Michael Tytgat Nov 05 '15 at 21:14
1

Well then you need to adjust it to accommodate the item list -- which was not a part of your question. – Sterling Archer Nov 05 '15 at 21:16

Difficulties adding onclick to a link with javascript

1 Answers1