Why does eclipse say the scanner is never closed when it is?

Question

Eclipse says the scanner is never closed, and prompts me to suppress it, but it is closed.

public boolean hasPlayerAlreadyJoined(Player p) {
    try {
        Scanner scanner = new Scanner(joinedPlayers);
        while (scanner.hasNextLine()) {
            String name = scanner.nextLine();
            if (name.equals(p.getName())) {
                return true;
            }
        }
        scanner.close();
    } catch(Exception e){}
    return false;
}

I am guessing it is because of the while loop but I have never ran into an error like this before. Am I doing something wrong?

Check [Scanner is never closed](http://stackoverflow.com/questions/15613626/scanner-is-never-closed) — sam, Nov 06 '15 at 22:21

score 1 · Answer 1 · answered Nov 06 '15 at 22:21

1

put scanner.close(); inside the a finally clause so that it would be called at the end. It's the most optimal way :

Scanner scanner = new Scanner(joinedPlayers);
try {
   ....
}
catch(...) {
   ....
}
finally {
    scanner.close();
}

answered Nov 06 '15 at 22:21

Mohammed Aouf Zouag

17,042
4
41
67

1

Isn't it better to use try with resources? – Hovercraft Full Of Eels Nov 06 '15 at 22:23
It's better but It's restricted to Java 7. – Mohammed Aouf Zouag Nov 06 '15 at 22:26

Why does eclipse say the scanner is never closed when it is?

1 Answers1