Zipfile Method doesn't works

Question

I create a zip file with rockyou password and I tried to extractall files. But I got some issues. Doesn't matter how password I put in extractall always I will get:

('Bad password for file', <zipfile.ZipInfo object at 0x7f7928d14dc8>)

Code:

import zipfile

zfile = zipfile.ZipFile("./rockyou.zip")

pss = b"rockyou"

try:
    zfile.extractall(pwd = pss)

except RuntimeError as e:
    print(e)
    zfile.close()

If I pass a string I got another issue:

TypeError: pwd: expected bytes, got <class 'str'>

And I tried too:

pss = str.encode("rockyou")

And:

pss = bytes(str.encode("rockyou"))

And:

pss = bytes("rockyou".encode("UTF-8"))

why are you converting to bytes? why not just pass as string? — R Nar, Nov 06 '15 at 23:26
Please confirm that you can open the file, with that password, using a standard zip program. — Kevin, Nov 06 '15 at 23:33
have you seen [this?](http://stackoverflow.com/questions/7483138/python-the-zipfile-module-doesnt-seem-to-work-with-passwords) — R Nar, Nov 06 '15 at 23:33
@RNar yes, i tried to create a compatible zip but is the same error — Radagast, Nov 06 '15 at 23:37
an ugly (but functional) solution is: `os.system('7z e -y -p"password" filename.zip')` after importing `os` — William, Nov 07 '15 at 00:01
@wil93, this worked, thanks, but for some reason zipfile method is broken... ;/ i tried a lot of things... but call in cmd worked thks — Radagast, Nov 07 '15 at 00:05
I created a zipfile with Unix `zip` and the code worked on that. Try the code on a simple file like that. Perhaps there's something about the zipfile you're using that's incompatible with the library. — Tom Zych, Nov 07 '15 at 00:19
@TomZych i'm on Ubuntu 15.10, can be that? and you used my code on post to test?, if not post yours — Radagast, Nov 07 '15 at 00:22
I used your code verbatim, and I'm on Debian. Very similar to your Ubuntu in most respects. — Tom Zych, Nov 07 '15 at 00:25
@TomZych ... i tried in a simple file that contains a txt file and i got the same erros... — Radagast, Nov 07 '15 at 00:35
Hmm. What locale is your computer using? Maybe when you type `rockyou` into the zip creator, it's not using the same coding as the Python program is? — Tom Zych, Nov 07 '15 at 00:37

score 7 · Answer 1 · answered May 03 '17 at 03:11

7

Well, I found a way to fix that, works for me, may not so beautiful...

  zFile.extractall(pwd = 'PASSWORD'.encode('cp850','replace'))

answered May 03 '17 at 03:11

Amarth Gûl

1,040
2
14
33

Thank you for that, was getting `TypeError: pwd: expected bytes, got ` – gaut Nov 01 '18 at 18:46

score 6 · Answer 2 · edited Jan 03 '19 at 22:20

6

I've been following the violent python book and in Chapter one you make a mini script to unlock a encrypted zip file. what worked for me was to add a b so the string would be in bytes:

import zipfile
zFile = zipfile.ZipFile("evil.zip")
zFile.extractall(pwd=b'secret') #this is what i'm talking about

edited Jan 03 '19 at 22:20

Amarth Gûl

1,040
2
14
33

answered Jun 04 '17 at 05:48

Nerf D

143
1
8

as commented above, looks like that is a compatibility issue between zipfiles encryption, so if you encrypt your file with AES-256 will get the error. i don't know if was fixed, but the correct way is passing bytes in pwd-param and encrypt your file with zipcrypto encription mode. – Radagast Jun 06 '17 at 10:12

Zipfile Method doesn't works

2 Answers2