Spring RestController interacting with other Java classes

Question

I'm quite new to Spring. I've used it before to make a REST API and I'm using it again now for the same purpose.

In addition to hosting the REST service, this program also repeatedly opens a file, scans for patterns, and maintains a structure of what it finds.

Right now we're starting that control flow here.

@SpringBootApplication
@EnableWebSecurity
public class Application {

  public static void main(String[] args) {
    SpringApplication.run(Application.class, args);
    SSHParser parser = new SSHParser();
    parser.startParserLoop();
  }
}

In the RestController we want to have a reference to that parser object so we can use it in the HTTP request methods.

@RestController
public class RestController {

  @Autowire
  SSHParser parser;

  @RequestMapping("/api/list")
  public Entry[] getList()  {
    return parser.list();
  }
}

I think I understand we could do something like the above, but this creates a new instance of SSHParser when what we really need is the instance parser from the main method.

Is this something we're just not meant to do with the Spring framework? Would it be possible to call the constructor for the rest controller ourselves to pass a reference that way?

Daniel Olszewski · Accepted Answer · 2015-11-12T08:08:58.903

You should create the SSHParser object as a Spring bean to make it possible to inject with the @Autowired annotation. Change your Application class to something like this:

@SpringBootApplication
@EnableWebSecurity
public class Application {

  public static void main(String[] args) {
    SpringApplication.run(Application.class, args);
  }

  @Bean
  public SSHParser sshParser() {
    SSHParser parser = new SSHParser();
    parser.startParserLoop();
    return parser;
  }

}

This code does exactly the same what your does, but in addition, it allows to reuse the created instance in other objects managed by the Spring container. By default, Spring creates a bean in the singleton scope so you'll have only one instance of SSHParser.

score 0 · Answer 2 · answered Nov 12 '15 at 07:43

0

In order to be able to autowire it, you will need to configure it as a Spring bean:

@Configuration
public class AppConfig {
    @Bean
    public SSHParser createSSHParser() {
        SSHParser parser = new SSHParser();
        parser.startParserLoop();
        return parser;
    }
}

The @Configuration class and the method name may be called what you like

answered Nov 12 '15 at 07:43

morsor

1,263
14
29

1

`@SpringBootApplication` is a wrapper for `@Configuration` and other annotations so no need to create another configuration class – Daniel Olszewski Nov 12 '15 at 08:08
@Daniel Olszewski: Ah OK. Did not know that - but saw your solution which points that out. It is certainly shorter. – morsor Nov 12 '15 at 08:33

RPresle · Answer 3 · 2015-11-12T07:50:44.493

0

At the moment you are injecting your SSHParser in the controler too. If you only want to have one instance of the SSHParser then you should consider using a singleton pattern

puclic class SSHParser {
    private static SSHParser instance;
    private SSHParser() {
    //private constructor, no one can instanciate this class
    }
    public static SSHParser getInstance() {
        if(SSHParser.instance==null) {
            SSHParser.instance = new SSHParser();
        }
        return SSHParser.instance;
    }
}

Then in your controller just call the getInstance method to get one unique instance. If you cannot modify the SSHPArser class then you can set up a wrapper or a Factory.

edited Nov 12 '15 at 07:50

answered Nov 12 '15 at 07:44

RPresle

2,436
3
24
28

It also makes your code impossible to test as it prevents you from stubbing or mocking the reference to SSHParser – Daniel Olszewski Nov 12 '15 at 08:01
Compare to Spring injection, it's true. But you can still use Frameworks to test static method as [PowerMock](http://stackoverflow.com/questions/21105403/mocking-static-methods-with-mockito). It another framework to use, may be annoying but there is a solution =) But anyway I prefer your solution (which was unknown to me). – RPresle Nov 12 '15 at 08:23

score 0 · Answer 4 · answered Nov 12 '15 at 07:50

You don't need to instanciate the SShParser yourself in the main method. Pull it from spring using the ApplicationContext.

@SpringBootApplication
@EnableWebSecurity
public class Application {

   public static void main(String[] args) {
      ConfigurableApplicationContext context=SpringApplication.run(Application.class, args);
      SSHParser parser = (SSHParser) context.getBean(SSHParser .class);
      parser.startParserLoop();
  }
}

spring will create only one instance of the SSHParser bean an use it with all the services that require it.

Spring RestController interacting with other Java classes

4 Answers4