constructor opens a file with a given filename c++

Question

In my code below errors occur and the program will not run, I am required to make a Constructor that must open the file with the given filename. If the filename does not exist then it Prints an error message and terminates the program.

Below is the code that I have done so far in C++:

#include "ReadWords.h"
#include <iostream>
#include <cstdlib>

using namespace std;

ReadWords::ReadWords(const char filename[])
{
    wordfile.open(filename);
    if (!wordfile)
    {
        cout << "cannot make " << filename << endl;
        exit(1);
    }
}

void ReadWords::close()
{
    wordfile.close();
}

Can you be a bit more specific when you say "errors occur"? What errors? What do they say? Are they compile time or runtime errors? — Greg Hewgill, Nov 15 '15 at 23:18
Can you please post all of the code? this looks like only a part of it. — EkcenierK, Nov 15 '15 at 23:23
it's more normal to place your own includes *after* the standard includes — M.M, Nov 15 '15 at 23:27

score 0 · Answer 1 · answered Nov 15 '15 at 23:23

0

Why dont you try including fstream to the top of your file and see if that works

answered Nov 15 '15 at 23:23

OneTrueSen

13
5

score 0 · Answer 2 · edited May 23 '17 at 12:15

0

I suppose wordfile is of type std::fstream. If your ReadWords.h #includes <fstream>, it should work (compiles and works as expected).

By the way, it's a bad practice to use using namespace std;.

Also, since you use C++, take a look at std::string. It's safer than using plain char* or char[].

edited May 23 '17 at 12:15

Community

1
1

answered Nov 15 '15 at 23:40

Zereges

5,139
1
25
49

constructor opens a file with a given filename c++

2 Answers2