findViewById(R.id.tabhost) always return null

Question

I have an app in Google play already and has no problem at all until I upgrade my Android Studio. The build.gradle has to be modified so that the project can be compiled Here is what I changed:

dependencies {
    compile fileTree(dir: 'libs', include: '*.jar')
    compile 'com.android.support:appcompat-v7:21.0.0'
    compile 'com.google.android.gms:play-services:6+'
    compile 'com.android.support:support-v4:+'
}

The only change is com.android.support:appcompat-v7:+ which is changed to com.android.support:appcompat-v7:21.0.0.

My problem is the .findViewById(R.id.tabhost) always return null so that the application crashes. Here is my layout file:

<?xml version="1.0" encoding="utf-8"?>
<android.support.v4.app.FragmentTabHost xmlns:android="http://schemas.android.com/apk/res/android"
    android:id="@+id/tabhost"
    android:layout_width="match_parent"
    android:layout_height="match_parent" >

My java code:

import android.support.v4.app.Fragment;
import android.support.v4.app.FragmentTabHost;

public class MenuLeftFragment extends Fragment {
    private FragmentTabHost mFragmentTabHost;

    @Override
    public void onActivityCreated(Bundle savedInstanceState) {
        super.onActivityCreated(savedInstanceState);
        mView = getView();
        if (mView != null) {
            mFragmentTabHost = (FragmentTabHost) mView
                    .findViewById(R.id.tabhost);

Any idea? Thanks.

http://stackoverflow.com/a/9505298/4265739 – leonardkraemer Nov 18 '15 at 14:24 — leonardkraemer, Nov 18 '15 at 14:24
Post your full code along with onCreateView() for fragment. – Arslan Ashraf Nov 18 '15 at 14:25 — Arslan Ashraf, Nov 18 '15 at 14:25

score 5 · Accepted Answer · answered Nov 18 '15 at 14:25

You should do this in onCreateView() where you should define as follows :

 @Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
        Bundle savedInstanceState) {
    View v = inflater.inflate(R.layout.your_layout, container, false);
    mFragmentTabHost = (FragmentTabHost) v.findViewById(R.id.tabhost);
    return v;
}

If you want to keep this code, the getView() on the onActivityCreated() is wrong, if you have a view on your onCreate() you can do something like :

mView = v;

Then in your onActivityCreated() instead of call getView() use mView

Then it should work.

Thanks, make sense. So strange my code is working in Google play for so long already. — Bagusflyer, Nov 19 '15 at 02:08

findViewById(R.id.tabhost) always return null

1 Answers1