11

I want to identify my archive whether it is zip or rar. But the problem I get runtime error before I can validate my file. I want to create custom notification:

public class ZipValidator {
  public void validate(Path pathToFile) throws IOException {
    try {
      ZipFile zipFile = new ZipFile(pathToFile.toFile());
      String zipname = zipFile.getName();
    } catch (InvalidZipException e) {
      throw new InvalidZipException("Not a zip file");
    }
  }
}

At the moment I have runtime error:

java.util.zip.ZipException: error in opening zip file

Himani Trivedi
  • 158
  • 2
  • 3
  • 16
Jack
  • 209
  • 1
  • 3
  • 10

6 Answers6

25

I'd suggest to open a plain InputStream an reading the first few bytes (magic bytes) and not to rely on the file extension as this can be easily spoofed. Also, you can omit the overhead creating and parsing the files.

For RAR the first bytes should be 52 61 72 21 1A 07.

For ZIP it should be one of:

  • 50 4B 03 04
  • 50 4B 05 06 (empty archive)
  • 50 4B 07 08 (spanned archive).

Source: https://en.wikipedia.org/wiki/List_of_file_signatures

Another point, just looked at your code:

Why do you catch die InvalidZipException, throw it away and construct a new one? This way you lose all the information from the original exception, making it hard to debug and understand what exactly went wrong. Either don't catch it at all or, if you have to wrap it, do it right:

} catch (InvalidZipException e) {
  throw new InvalidZipException("Not a zip file", e);
}
bratkartoffel
  • 1,127
  • 1
  • 13
  • 37
20

Merging the answers of nanda & bratkartoffel.

private static boolean isArchive(File f) {
    int fileSignature = 0;
    try (RandomAccessFile raf = new RandomAccessFile(f, "r")) {
        fileSignature = raf.readInt();
    } catch (IOException e) {
        // handle if you like
    }
    return fileSignature == 0x504B0304 || fileSignature == 0x504B0506 || fileSignature == 0x504B0708;
}
wcmatthysen
  • 445
  • 4
  • 19
Fabian Braun
  • 3,612
  • 1
  • 27
  • 44
4

Exception is thrown in line

ZipFile zipFile = new ZipFile(pathToFile.toFile());

That's because if a non-ZipFile is given as parameter for the ZipFileconstructor the ZipException is thrown. So you have to check before generating a new ZipFile Object if your file path points to a correct ZipFile. One solution might be to check the extension of the file path like so

 PathMatcher matcher = FileSystems.getDefault().getPathMatcher("glob:*.zip");
 boolean extensionCorrect = matcher.matches(path); 
hatze
  • 521
  • 4
  • 12
4
RandomAccessFile raf = new RandomAccessFile(f, "r");

long n = raf.readInt();

raf.close();

if (n == 0x504B0304)

    System.out.println("Should be a zip file");

else

    System.out.println("Not a zip file");

You can see it in the following link. http://www.coderanch.com/t/381509/java/java/check-file-zip-file-java

Abhinav Singh Maurya
  • 3,313
  • 8
  • 33
  • 51
nanda
  • 161
  • 1
  • 10
0

Apache Tika was created to extract metadata from files, but one of its side benefits is it will determine a file's media-type by either its magic bytes and/or the files extension.

public String detect(InputStream stream, String name) throws IOException

Detects the media type of the given document. The type detection is based on the content of the given document stream and the name of the document.

hooknc
  • 4,854
  • 5
  • 31
  • 60
0

I resolved it using Apache Tika (here for gzip):

final MimeTypes mimeTypes = MimeTypes.getDefaultMimeTypes(ClassLoader.getSystemClassLoader());
boolean isCompressed = mimeTypes.forName("application/gzip").matches(
        FileUtils.readFileToByteArray(FileUtils.getFile(filepath))
);

Remark: the library use the magic bytes, so it should be possible to read only some start bytes of the file instead of using FileUtils.getFile().

Olivier Faucheux
  • 2,520
  • 3
  • 29
  • 37