Java toString() not printing the correct variable

Question

I have a class like this in Java:

public class Wrapper {
    public static List<Type> list;

    @Override
    public String toString() {
        return "List: " + this.list;
    }

    public static void main(String[] args) {
        Wrapper w = new Wrapper();
        System.out.println(w);
    }
}

and a class like this:

public class Type {
    private static String name;

    public Type(String n) {
        this.name = n;
    }

    @Override
    public String toString() {
        return this.name;
    }
}

Instead of getting the name of each item, I get the name of the last item for each item in the array. Any suggestions?

try remove that `static` word for the variable name and try it again ;) — kucing_terbang, Dec 02 '15 at 04:41
I would agree that this is a duplicate, but to be fair, I don't think that I would've found that answer from Googling/searching on SO, as I thought this was a problem of toString... — user1947561, Dec 02 '15 at 04:52
in class `Type` `private static String name;` should be `private String name`. its not a static field (or shouldn't be the way you are using it in the constructor. — ptierno, Dec 02 '15 at 04:59

score 6 · Accepted Answer · answered Dec 02 '15 at 04:43

6

in your Type class you are marking your name as static so when printing type.toString() you always have only one value. And if you want to print all member of your list, use:

for(Type t : list){
   System.out.print(t.toString());
}

answered Dec 02 '15 at 04:43

Mingo.Link

168
5

Thanks! This works. Thank you also to @kucing_terbang for the comment! I'll accept this when I can. – user1947561 Dec 02 '15 at 04:45
1

He is trying to return from toString(), not print to the console. – Mark Aldrich Dec 02 '15 at 04:45
If this is your answer, please mark it as correct answer – HungPV Dec 02 '15 at 04:46
Yes I know and I know he understand what I mean. – Mingo.Link Dec 02 '15 at 04:47
2

+1. Note that good IDEs and compilers emit a warning for this code, since `this.name` is misleading when `name` is static. – ruakh Dec 02 '15 at 04:47
@user1947561 please read about static, agains. You are using incorrect way of static. – Mingo.Link Dec 02 '15 at 04:48

score -1 · Answer 2 · answered Dec 02 '15 at 04:44

-1

@Override
public String toString() {
    String s = "";
    for(Type t : list) {
        s += t;
    }
    return s;
}

answered Dec 02 '15 at 04:44

Mark Aldrich

26
5

add some text with answer to explain how your answer help OP or others in solving issue – ρяσѕρєя K Dec 02 '15 at 05:36

Java toString() not printing the correct variable

2 Answers2