How to use arrays in Hangman game C

Question

Don't know how to solve it further.

 #include<stdio.h>
 #include<conio.h>
 #include<stdlib.h>
 #include<string.h>

 void main()   
 {

    printf( "                  Welcome To Hangman!:)           \n");
    printf( " All the Best (y)   \n");
    printf( "You can play it 3 time \n");
    printf( "You have 6 chances for wrong guesses\n");

    int x=0;
    while (x<3)
    {
        char word[]="pakistan";
        /*
        string[1]="india";
        string[2]="america";
        string[3]="aferica";
        string[4]="spain";
        string[5]="china";
        int wrong = 1;
        char word=rand()%5;
        */
        int wrong=0;
        int new=0;
        char so_far[strlen(word)];
        int I;
        for(I=0; I<strlen(word); I++)
        {
            so_far[I] = '_';
        }


        while(wrong<=7 && strcmp(so_far, word)!=0)
        {
            printf("so far the word is: %c\n", so_far);
            char guess;
            printf("enter your guess: ");
            scanf("%c", &guess);
            //guess=guess.upper();

            int i=0;
            //if (new==1)
        //  {


            for(i=0;i<strlen(word);i++)
                    {
                        if (word[i]==guess)

                //  if (guess==word[i])

                        //new+=guess;
                        so_far[i]=guess;
                        new=1;

                //  else

                    //  new+=so_far[i];
                }


        //  so_far[i]=new;
        //  }
            //else
            if(new!=1)
            {
                printf("\nsorry '%c' is not in the word\n",guess);
                printf("\nyour wrong guesses are: %d\n",wrong);
                if (wrong ==1)
                    {
                            printf("\n      +------- \n");
                            printf("       |   |  \n");
                            printf("       |   O  \n");
                            printf("       |    \n");
                            printf("       |    \n");
                            printf("       |    \n");
                            printf("       |    \n");
                            printf("       |    \n");
                            printf("       =============\n");
                }
                if( wrong==2)
                {
                        printf("\n       +------- \n");
                        printf("       |   |  \n");
                        printf("       |   O  \n");
                        printf("       |   | \n");
                        printf("       |   | \n");
                        printf("       |    \n");
                        printf("       |    \n");
                        printf("       |    \n");
                        printf("       =============\n");
                }
            if (wrong==3)
               {
                    printf("\n       +------- \n");
                    printf("       |    |  \n");
                    printf("       |    O  \n");
                    printf("       |    |____   \n");
                    printf("       |    | \n");
                    printf("       |    |  \n");
                    printf("       |    \n");
                    printf("       |    \n");
                    printf("       =============\n");
            }
            if( wrong==4)
                {
                    printf("\n       +------- \n");
                    printf("       |    |  \n");
                    printf("       |    O  \n");
                    printf("       |____|____   \n");
                    printf("       |    | \n");
                    printf("       |    |  \n");
                    printf("       |    \n");
                    printf("       |    \n");
                    printf("       =============\n");
            }
            if( wrong==5)
                {
                printf("\n         +-------\n");
                printf("         |     |\n");
                printf("         |  ___O___\n");
                printf("         |     |\n");
                printf("         |     | \n");
                printf("         |      |\n");
                printf("         |      |  \n");  
                printf("       ==============\n");

                }
            if (wrong==6)
                {
                printf("\n         +-------\n");
                printf("         |     |\n");
                printf("         |  ___O___\n");
                printf("         |     |\n");
                printf("         |     | \n");
                printf("         |   |   |\n");
                printf("         |   |   |  \n");  
                printf("       ==============\n");
            }
            //wrong+=1;
            }
        wrong+=1;
        }
        if (wrong==7)
        {
            printf("you lose and your hanged :(\n");

        }
        else
        {
            printf("you guessd it. Good\n");
        }
        printf("the word is: %c\n",word);



        x++;
        printf("play once again\n");
    }
    printf("game over\n");
    getch();

}

The else statement is not working properly and loop of wrong<7,instead of printing once, is printing twice. please help

Set `wrong` to 7 when the user guesses the whole world correctly so that the loop will break. Also, `printf("the word is: %c\n",word);` won't work. `%c` is for a single character, you want `%s` for a string. — David Schwartz, Dec 05 '15 at 09:47
Also, `printf("so far the word is: %c\n", so_far);` is doubly broken. Again, `%c` is for a single character, but here you can't change it to `%s` because `so_far` is not a string. (How would `printf` know how many characters to print?) — David Schwartz, Dec 05 '15 at 09:48

score 0 · Accepted Answer · edited May 23 '17 at 12:04

# include <stdio.h>
# include <conio.h>
#include <stdlib.h>
#include  <string.h>
void main()

{

printf( "                  Welcome To Hangman!:)           \n");
printf( " All the Best (y)   \n");
printf( "You can play it 3 time \n");
printf( "You have 6 chances for wrong guesses\n");

int x=0;

    int static ne=0;
while (x<3)
{
    char word[]="pakistan";
    /*
    string[1]="india";
    string[2]="america";
    string[3]="africa";
    string[4]="spain";
    string[5]="china";
    int wrong = 1;
    char word=rand()%5;
    */
    int wrong=0;

    char so_far[strlen(word)];
    int I;
    for(I=0; I<strlen(word); I++)
    {
        so_far[I] = '_';
    }

      char guess;
    while(wrong<7 && strcmp(so_far, word)!=0)
    {

            int i;
        printf("so far the word is: %s\n", so_far);

        printf("enter your guess: ");
        scanf(" %c", &guess); //main problem was here as you have not provided any space before %c it was skipping once and calling it twice


        for(i=0;i<strlen(word);i++)
                {
                    if (word[i]==guess )
                    {
                    so_far[i]=guess;
                    ne=1;// variable to check whether any character matched or not
                    }
                }
            if(ne==0)//if not matched then enter here
        {   system("cls");
            printf("\nsorry %c is not in the word\n",guess);
            printf("\nyour wrong guesses are: %d\n",wrong+1);

        wrong+=1;
            }

        ne=0;

    }
        if (wrong==7)
    {
        printf("you lose and your hanged :(\n");

    }
    else
    {
        printf("you guessd it. Good\n");
        printf("the word is: %s\n",word);

    }

    x++;
    printf("play once again\n");
}
printf("game over\n");
getch();
}

for better understanding of scanf with and without space follow this answer What does space in scanf mean?

you can add your animation as before. – Shvet Chakra Dec 05 '15 at 11:54 — Shvet Chakra, Dec 05 '15 at 11:54

score -1 · Answer 2 · answered Dec 05 '15 at 09:41

-1

When user guessed correctly (program enters the else part) you should break. If not, it is going to be loop again and print it twice or more.

answered Dec 05 '15 at 09:41

cengineer

1,362
1
11
18

How to use arrays in Hangman game C

2 Answers2