How to change text in each string in all text files c#

Question

I have code that is supposed to replace the word "simple" with the word "word" within all text files in the given directly, but I do not know what to correct in order for the code to work.

static void Main(string[] args)
        {
            // Например, получаем все файлы определённого типа в заданной директории.
            string[] fileList = Directory.GetFiles(@"C:/Users/Users/Desktop/a/","*.txt");
            foreach (var filePath in fileList) // Для каждого пути файла...
            {
                for (int i = 0; i < filePath.Length; i++)
                {
                    var lines = File.ReadAllText(filePath);
                    lines = lines.Replace("simple", "word");
                    File.WriteAllText(filePath, lines);
                }
            }
        }

What is the purpose of the for loop within the foreach loop? — Lewis Taylor, Dec 06 '15 at 14:59
I quite good know what the code is doing< i do not know how to get the title — komra23, Dec 06 '15 at 15:00

score 1 · Answer 1 · answered Dec 06 '15 at 15:09

1

I imagine that your code is taking a while because of the line

for (int i = 0; i < filePath.Length; i++)

which makes the code occur for each individual character within each file. Simply remove it like so.

static void Main(string[] args)
{

    string[] fileList = Directory.GetFiles(@"C:/Users/Users/Desktop/a/","*.txt");
    foreach (var filePath in fileList) // Для каждого пути файла...
    {
        var lines = File.ReadAllText(filePath);
        lines = lines.Replace("simple", "word");
        File.WriteAllText(filePath, lines);
    }
}

answered Dec 06 '15 at 15:09

Sophie Coyne

1,018
7
16

it cannot find a text file – komra23 Dec 06 '15 at 15:12
It may be a problem with the directory. – Sophie Coyne Dec 06 '15 at 15:13
yes, problem was in incorrect path – komra23 Dec 06 '15 at 15:18
Coolioso, so did I help then? – Sophie Coyne Dec 06 '15 at 15:20
i think that may be yes – komra23 Dec 06 '15 at 15:24
but if i write ReadAllLines instead of ReadAllText, it Italic text=text.(Replace) in brackets – komra23 Dec 06 '15 at 15:26
Sorry, what do you want to do with each line? – Sophie Coyne Dec 06 '15 at 15:31

score 0 · Answer 2 · answered Dec 06 '15 at 15:03

0

Your double for loop reads "for each file, do something for each character in the file's path name"

I highly doubt that is what you want since you don't use the i variable anywhere

answered Dec 06 '15 at 15:03

OneCricketeer

179,855
19
132
245

i need to change text in each string in all text files smth text – komra23 Dec 06 '15 at 15:05
Assuming those innermost 3 lines work correctly, then put them within the first for loop – OneCricketeer Dec 06 '15 at 15:06
can you write code or you simply give suggestions ? – komra23 Dec 06 '15 at 15:08
I want you to think about what your code is actually doing rather than just giving you an answer you can copy and paste – OneCricketeer Dec 06 '15 at 15:10

How to change text in each string in all text files c#

2 Answers2