i am trying to add a text to my output
def as():
a = 0
return a
def d():
return d
Asked
Active
Viewed 64 times
0
-
1`d` is a list, not a dictionary. Also, you `return` on the first iteration of the loop. – jonrsharpe Dec 07 '15 at 20:51
-
yes by mistake i changed return's position but still i dont know what to put in d?? – jason Dec 07 '15 at 20:56
-
What happens when a value repeats or the value is not hashable? – Padraic Cunningham Dec 07 '15 at 21:01
-
well i have a problem when the value repeats i dont understand it – jason Dec 07 '15 at 21:45
1 Answers
0
You are using a list for some reason instead of a dictionary. Use generator to reverse key/value pairs:
def index_by_author(f):
from library import load_library
return {value: key for key, value in load_library().items()}
midori
- 4,807
- 5
- 34
- 62
-
-
-
-
it is a dictionary and i already finished the load_library and its working – jason Dec 07 '15 at 21:08
-
-
-
def load_library(f): with open(f,'rt') as x: return dict(map(str.strip, line.split("|")) for line in x) – jason Dec 07 '15 at 21:11
-
-
i would also recommend to make imports at the top of your py file, not inside the function – midori Dec 07 '15 at 21:14
-
thanks now it works but the problem that the value has 2 similar in the dictionary ...... – jason Dec 07 '15 at 21:22
-
(Foundation|Asimov, Isaac) (Foundation and Empire|Asimov, Isaac) (Second Foundation|Asimov, Isaac) (Dune|Herbert, Frank) (Children of Dune|Herbert, Frank) (RUR|Capek, Karel) (2001: A Space Odyssey|Clarke, Arthur C.) (2010: Odyssey Two|Clarke, Arthur C.) – jason Dec 07 '15 at 21:24
-
it doesn't care if any other key/value pairs are similar, it will invert every key/value pair – midori Dec 07 '15 at 21:24
-
-
we are not dealing with any files in index_by_author, btw what is f parameter which you supply for a function, but never use? – midori Dec 07 '15 at 21:30
-
it is a file 'books.txt' which is provided automatically by the automatic check – jason Dec 07 '15 at 21:32
-
-
oh i see what you mean, you need to provide your file name as a string in the load_library function, i thought it was obvious since you wrote it – midori Dec 07 '15 at 21:35
-
yes exactly , is it possible to change the {} to a list or tuple because its not accepting the {} – jason Dec 07 '15 at 21:37
-
-
can you update your question with everything you have, it's not quite obvious what you're trying to achive – midori Dec 07 '15 at 21:39
-
-
ok, instead of f you need to provide a real file name as a string with path if it's not in the same folder. So keep use it like this {value:key for key, value in load_library('any_file.txt').items()} – midori Dec 07 '15 at 21:47
-
still the same error i think its not accepting the {} i dont understand it – jason Dec 07 '15 at 21:52
-
you need to provide a file name like this: 'file.txt' why do you try to put {} instead? – midori Dec 07 '15 at 21:53
-
yes i provided the 'file.txt' but it says with open(f,'rt') as x: FileNotFoundError: [Errno 2] No such file or directory: 'books.txt' – jason Dec 07 '15 at 21:57
-
-
yes i think theres something wrong with the automatic check but when i test it in pycharm i got two lists of the same solution? – jason Dec 07 '15 at 22:02
-
it works from the cli and any ide, i don't know what the automatic check is – midori Dec 07 '15 at 22:03
-
yes i will check with my tutor , thank you very much you really helped me :) – jason Dec 07 '15 at 22:05
-
by the way you don't have to do that from library import load_library if both functions in the same py file – midori Dec 07 '15 at 22:06
-
yes when i removed it i got one list but still its not working with the automatic check :( – jason Dec 07 '15 at 22:13