Static class and Session variables

Question

I have defined a static class. In that static class I have the following method.

public static int GetUserId()
{
    if(IsUserLoggedIn())
    {
        return Convert.ToInt16(HttpContext.Current.Session["user"]);
    }
    return 0;
}

My question is this: When that function run for each user, will each user get a different value? (considering each user session gets different userId for the Session["user"].

I don't know if a static class is useful for this or can cause conflict issues. I am developing in C#/ASP.NET.

Yes it would get different values if all session has set different values. There is nothing to do with the static implementation of `GetUserId` method. — Jenish Rabadiya, Dec 09 '15 at 08:29
@paulsm4 What makes you think would cause the compilation error? — Jenish Rabadiya, Dec 09 '15 at 08:32
@JenishRabadiya Even when I read about static classes I had problem fully understanding it's limitations. thanks for clarifying this. — Liron Harel, Dec 09 '15 at 08:33

score 5 · Accepted Answer · edited Mar 11 '18 at 11:17

In short, I believe the answer is yes, however you should avoid having hard-coded dependencies in non-factory methods... Consider accepting a HttpSessionState or at the very least a HttpContext object to act on, like so:

public static int GetUserId(HttpContext context)
{
    if(IsUserLoggedIn())
    {
        return Convert.ToInt16(context.Session["user"]);
    }
    return 0;
}

You should, however, likely be using the built in IPrincipal (User) property on the HttpContext, IMHO.

score 1 · Answer 2 · answered Dec 09 '15 at 08:31

1

HttpContext will be different for every request so yes.

answered Dec 09 '15 at 08:31

Avi

1,924
3
17
31

score 1 · Answer 3 · edited May 23 '17 at 12:15

1

This will give you a error(calling non-static method from static method.). Please refer this :-

calling non-static method in static method in Java

edited May 23 '17 at 12:15

Community

1
1

answered Dec 09 '15 at 08:40

Sahi

1,454
1
13
32

I don't see any such calls (HttpContext.Current is static) and the question is about C# not Java. – Stephen Kennedy Mar 11 '18 at 10:55

Static class and Session variables

3 Answers3