Function not returning the value - undefined

Question

Did build a function to return the index of element from a group of elements. But when I try to pass the value to another variable (myindex) I do get undefined.

Here the Javascript source code

$(document).ready(function(){
             $("[id*='_CG']").addClass("form-control input-sm text-right");
    $("[id*='_Weight']").addClass("form-control input-sm text-right");
    $("[id*='TXFuelWeight']").addClass("form-control input-sm text-right");
    $("[id*='TRPFuelWeight']").addClass("form-control input-sm text-right");

      myindex = GetLSElementIndex("[id*='W_OP_']", "W_OP_CAB1Items");
alert (myindex);

            });
 // Get the index element in a group of element
 function GetLSElementIndex(ElementGroup, Element) {
    $(ElementGroup).each(function (index) {
        var someText = $(this).attr('id');
        if (someText == Element) {
            alert(someText);
            alert(index);
            //GetLSElementIndex = index;
            //alert(GetLSElementIndex);
            return ;
            //return index;

        }


    });

}

Example

You are returning nothing i.e. `undefined` Try `return index` — Rayon, Dec 10 '15 at 04:33
Use `return $(ElementGroup).filter('#' + Element).index();`. [**Demo**](http://jsfiddle.net/tusharj/a9tsz5uz/4/) — Tushar, Dec 10 '15 at 04:37
You'll have to move the `return` out of the `.each()` iterator (and use another variable to provide the `index` value to it). The `return` keyword applies the value for the closest `function` that's around it. In this case, that's the `function (index) { ... }`. — Jonathan Lonowski, Dec 10 '15 at 04:42

score 0 · Answer 1 · answered Dec 10 '15 at 04:33

0

You need to use like this:

var indx;
if (someText == Element) {
    alert(someText);
    alert($('#'+Element).index());//Don't do just alert(index)
    indx = $('#'+Element).index();//I need to find index of ? #W_OP_CAB1Items
     return indx;
  }

answered Dec 10 '15 at 04:33

Bhojendra Rauniyar

83,432
35
168
231

score 0 · Answer 2 · answered Dec 10 '15 at 04:43

function GetLSElementIndex(ElementGroup, Element) {
    var value = -1; //If no element is found, index is assumed to be -1
    $(ElementGroup).each(function (index) {
        var someText = $(this).attr('id');
        if (someText == Element) {
            alert(someText);
            value = index;
            alert(value);
            return false;//To break out of each() once the index is found.
        }
    });
    return value; //Return the value (from the called fn) once the processing is done

}

score 0 · Answer 3 · answered Dec 10 '15 at 05:14

Rework your GetLSElementIndex method like this by defining one global variable for that method and assign that index of each loop to that and return it and then bring the return statement out of the each loop.

DEMO: FIDDLE

// Get the index element in a group of element
    function GetLSElementIndex(ElementGroup, Element) {
        var setIndex;
        $(ElementGroup).each(function (index) {
            var someText = $(this).attr('id');
            setIndex = index;
            if (someText == Element) {
                alert(someText);
                alert(index);
            }
        });
        return setIndex;
    }

Note: Index of last item's of each loop only will be return by this method.

score 0 · Answer 4 · edited May 23 '17 at 11:44

You must break "Jquery each" and than return index back. point of confusion is "Jquery each" break by "return false" statement. You must store index value in some local variable(var toReturn .. in function below). here is the modified GetLSElementIndex function for you

 // Get the index element in a group of element
 function GetLSElementIndex(ElementGroup, Element) {
   var toReturn; 
    $(ElementGroup).each(function (index) {
        var someText = $(this).attr('id');

       if (someText == Element) {
            //alert(someText);
           // alert(index);
            toReturn= index;
            //GetLSElementIndex = index;
            //alert(GetLSElementIndex);
            return  false ;
            //return index;

        }

    });
     return toReturn;

}

for more details please follow other question of Stack Overflow

score 0 · Accepted Answer · answered Dec 10 '15 at 05:25

Update your function to store the index of desired element in a variable and then return the variable.

function GetLSElementIndex(ElementGroup, Element) {
   var elementIndex;/* store the index of #element here */  
   $(ElementGroup).each(function (index) {
       var someText = $(this).attr('id');
       if (someText == Element) {
           elementIndex = index;
       }
   });
   return elementIndex; /* will return index of #element if found otherwise will return undefined */
}

Have removed all the alerts as I assume those are for debugging purposes.

Function not returning the value - undefined

5 Answers5