Sailsjs - Continue executing after return res.json();

Question

It continues execution even if the condition is true and return res.json() is executed.

_.each(rooms, function(room){
    if(room.users.length == users.length) {
        return res.json(room); // <-- returns but still continuous execution
    }
});

Below is the error printed in console.

error: Error: Cannot write to response more than once

Do I need to do anything else?

score 0 · Answer 1 · answered Dec 10 '15 at 08:10

0

you should break the loop and then res.status(200).json(room)

answered Dec 10 '15 at 08:10

Tuan Anh Tran

6,807
6
37
54

Thanks for fast reply, But as its a callback function the break is not working there. :( – Sahil Deliwala Dec 10 '15 at 08:16

score 0 · Accepted Answer · edited May 23 '17 at 12:30

As posted in How to break/exit from a each() function in JQuery?, you can exit each loops by returning false. Thus,

_.each(rooms, function(room){
    if(room.users.length == users.length) {
        res.json(room);
        return false;
    }
});

If that did not work and you used underscore.js, see how to break the _.each function in underscore.js which recommends using .every where return false works (instead of .each). Thus

_.every(rooms, function(room){
    if(room.users.length == users.length) {
        res.json(room);
        return false;
    }
});

score 0 · Answer 3 · answered Dec 10 '15 at 10:04

0

You could consider using a different function in the underscore/lodash api, for example, find would seem to suit what you are doing better:

var room = _.find(rooms, function(room){
  return room.users.length == users.length;
});
res.json(room);

answered Dec 10 '15 at 10:04

BrettJephson

416
5
13

This is awesome. :) I changed my code. This works great. Thanks – Sahil Deliwala Dec 11 '15 at 10:34

Sailsjs - Continue executing after return res.json();

3 Answers3