Chrome Extension: Issue with passing a parameter

Question

This is working:

function click(e) {
    chrome.tabs.executeScript(null, {
        code: 'var money = 1;'
    }, function() {
        chrome.tabs.executeScript(null, {file: 'peace.js'});
    });
}

This is not (edited the code for ease):

function click(e) {

    var test = 'test';
    chrome.tabs.executeScript(null, {
        code: 'var money = ' + test + ';'
    }, function() {
        chrome.tabs.executeScript(null, {file: 'peace.js'});
    });
}

How can I pass it correctly? Thanks!

Have you tried looking into what `e` is? Add `console.log(e)` into the function and see what it is. — jianweichuah, Dec 14 '15 at 23:40
yes, when i console.log it, it shows correctly. just not passing to `peace.js` — Sam, Dec 14 '15 at 23:41
I think this is just injecting the js code into the page, not passing it over to `peace.js`. https://developer.chrome.com/extensions/tabs#method-executeScript How does `var money = 1;` work? — jianweichuah, Dec 14 '15 at 23:47
@jianweichuah, it is passing when I do it like the first time, but it is not passing when I do it as second time. When I `console.log(e.target.id)`, it works well. — Sam, Dec 14 '15 at 23:52
How did you verify that `var money = 1;` was correctly passed over to peace.js? Did you read the value from there? — jianweichuah, Dec 14 '15 at 23:59

score 1 · Answer 1 · answered Dec 15 '15 at 00:22

I think your problem is the string value is not formatted correctly. For example,

function click(e) {
    var test = 'test';
    chrome.tabs.executeScript(null, {
        code: 'var money = ' + test + ';'
    }, function() {
        chrome.tabs.executeScript(null, {file: 'peace.js'});
    });
}

Wouldn't work because when var money=test; is executed, the script doesn't know what test is.

If you wanna pass a string over, it should be

function click(e) {

    var test = 'test';
    chrome.tabs.executeScript(null, {
        code: 'var money = "' + test + '";'
    }, function() {
        chrome.tabs.executeScript(null, {file: 'peace.js'});
    });
}

This way, the executed code will be var money="test";

The portable way is to do a JSON encode. See duplicate. – Xan Dec 15 '15 at 10:02 — Xan, Dec 15 '15 at 10:02

score 0 · Accepted Answer · edited Dec 15 '15 at 10:00

Found a workaround:

if (e.target.id == 'test1') {
    chrome.tabs.executeScript(null, {
        code: 'var money = 1'
    }, function() {
        chrome.tabs.executeScript(null, {file: 'peace.js'});
    });
} else  if (e.target.id == 'test2') {
    chrome.tabs.executeScript(null, {
        code: 'var money = 2'
    }, function() {
        chrome.tabs.executeScript(null, {file: 'test.js'});
    });
}

Chrome Extension: Issue with passing a parameter

2 Answers2