0

I am using the MvcSiteMapProvider Html Helper to create a navbar. The content of the navbar depends on the visitor rights therefore I am using security trimming to only display content which the person is authorized for. For performance improvement I am trying to cache this navbar.

The navbar is created in a partial view with the following content:

@Html.MvcSiteMap().Menu("MenuHelper", new { name = "MainMenu" })

Inside the layout file it is called by an action method which returns the partial view:

[System.Web.Mvc.OutputCache(Duration = 10, VaryByCustom = "User")]
[ChildActionOnly]
public ActionResult MainMenu()
{
    return PartialView("MainMenu");
}

The caching of works fine at the root page of the sitemap. However when the cache duration runs out and the action method is called from deeper levels, no sitemap is returned. When I disable security trimming or the output caching it works perfectly fine at all levels.

Is it possible that action method which returns the navbar, is called when the authorization data is unavailable and therefore returns a corrupt sitemap?

Hello It's me
  • 538
  • 1
  • 11
  • 24

1 Answers1

0

If you analyze the source for AuthorizeAttribute, you will note that it is not designed to work with child actions that are output cached (they go to some great lengths to ensure that child actions that are output cached will throw an exception).

Of course, it also won't work right if you have a custom AuthorizeAttribute that overrides OnAuthorization that does not duplicate this important logic.

However, there are a couple of things you can do to improve performance when using Security Trimming:

  1. Make sure that your injection constructors are simple, especially on your controllers. If you have heavy processing in your constructors, it can really slow things down (with or without MvcSiteMapProvider, but Security Trimming makes this much more apparent).
  2. If that doesn't improve things enough and you are not using a custom AuthorizeAttribute, you could use the roles attribute/property to duplicate your role logic into the SiteMap and remove the AuthorizeAttributeAclModule from your configuration (external DI only).

See this discussion for more details.

NightOwl888
  • 55,572
  • 24
  • 139
  • 212
  • Does this still applies when only the action which uses the layout uses the `AuthorizeAttribute` and not the child action? – Hello It's me Dec 18 '15 at 16:36
  • I have never attempted to use `MvcSiteMapProvider` with output caching. My guess is that it will probably not work. It is meant to be dynamic and change with each request. Caching the output means that the `SiteMap` object will never get called and none of the logic will run that is supposed to run on every request - effectively bypassing security trimming and visibility providers. – NightOwl888 Dec 19 '15 at 15:47