Unable to start fragment from onListItemClick

Question

I'm trying to start a fragment from OnItemClickListener event of list view but its not showing anything. to check if the OnItemClickListener is functional or not, I've included a Toast to show some text and its working fine. Here is my code

Here is the code for ItemClickListener of main activity

        listView.setOnItemClickListener(new AdapterView.OnItemClickListener(){
        public void onItemClick(AdapterView<?> parent, View view, int position, long id){

            Fragment fragment = new Friendtilefragment();
            FragmentTransaction transaction = getFragmentManager().beginTransaction();
            transaction.replace(R.id.friendtilefragment, fragment);
            transaction.addToBackStack(null);
            transaction.commit();

            Toast.makeText(getApplicationContext(), "An item of the ListView is clicked.", Toast.LENGTH_LONG).show();
        }
    });

Code for the Friendtilefragment

package com.example.xxxxxxxx.socialoid;

import android.app.Fragment;
import android.os.Bundle;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;

public class Friendtilefragment extends Fragment {

@Override
public View onCreateView(LayoutInflater inflater,ViewGroup container, Bundle savedInstanceState) {
    return inflater.inflate(R.layout.friendtilefragment_layout, container, false);
}
}

mainactivity_layout.xml

<android.support.v4.widget.SwipeRefreshLayout
xmlns:android="http://schemas.android.com/apk/res/android"
android:id="@+id/swipe_refresh_layout"
android:layout_width="match_parent"
android:layout_height="wrap_content">

<ListView
android:id="@+id/list"
android:layout_width="fill_parent"
android:layout_height="wrap_content"
android:divider="@color/list_divider"
android:dividerHeight="1dp"
android:listSelector="@drawable/list_row_selector" />

<fragment
    android:id="@+id/friendtilefragment"
    android:name="com.example.xxxxxxxx.socialoid.Friendtilefragment"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    />
</android.support.v4.widget.SwipeRefreshLayout>

friendtilefragment_layout.xml

<?xml version="1.0" encoding="utf-8"?>

<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:orientation="vertical"
android:layout_gravity="center"
android:layout_width="match_parent"
android:layout_height="match_parent">
        <TextView
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:text="This is textview"/>

</LinearLayout>

change it Friendtilefragment fragment = new Friendtilefragment(); — Aditya Vyas-Lakhan, Dec 19 '15 at 05:13
@NigamPatro,It's not mandatory to take FrameLayout to adding fragment. — Haresh Chhelana, Dec 19 '15 at 05:15
@deejay,Might be your ListView take whole screen how many items in ListView ? — Haresh Chhelana, Dec 19 '15 at 05:15
@NigamPatro I've read other posts and some have used framelayout others are using Fragment.. so i think its not the issue.And if there was a problem with it, it must have shown some errors. — deejay, Dec 19 '15 at 05:17
@HareshChhelana I'm loading listview with json data and I've got only 2 items in my list. ListView height is set to WrapContent.. — deejay, Dec 19 '15 at 05:18
@deejay,Try to set SwipeRefreshLayout height as match_parent instead of wrap_content. — Haresh Chhelana, Dec 19 '15 at 05:27
@deejay move `Toast.makeText(getApplicationContext(), "An item of the ListView is clicked.", Toast.LENGTH_LONG).show();` to `Friendtilefragment`, see whether the Toast can get displayed in your fragment or not — John, Dec 19 '15 at 05:36
unreachable statement while using Toast in fragment..I've tried replacing getApplicationContext with getActivity() but unreachable. — deejay, Dec 19 '15 at 05:50
@deejay check this answer to know how change fragment http://stackoverflow.com/a/34357147/1140237 specifilcally `CollpaseScreen` activity — user1140237, Dec 19 '15 at 05:57

score 1 · Accepted Answer · edited May 23 '17 at 12:17

1

You have to create a FrameLayout in your MainActivity and move android:id="@+id/friendtilefragment" to FrameLayout.

Example in your mian_activity

<?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:orientation="vertical" android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:id="@+id/friendtilefragment">

<android.support.v4.widget.SwipeRefreshLayout
android:id="@+id/swipe_refresh_layout"
android:layout_width="match_parent"
android:layout_height="wrap_content">

.....

Between, change Fragment fragment = new Friendtilefragment(); to Friendtilefragment fragment = new Friendtilefragment();

Check this

edited May 23 '17 at 12:17

Community

1
1

answered Dec 19 '15 at 05:24

John

684
11
35

I'm trying this code.. and do i need to remove the fragment tag completely? – deejay Dec 19 '15 at 05:54
Ya, you can remove it and see whether it works or not – John Dec 19 '15 at 05:56
I mean the problem we discussed in chat, not here – John Dec 26 '15 at 12:42

score 0 · Answer 2 · answered Dec 19 '15 at 05:19

0

Replace

Fragment fragment = new Friendtilefragment();

with this

Friendtilefragment fragment = new Friendtilefragment();

answered Dec 19 '15 at 05:19

Rishad Appat

1,786
1
15
30

score 0 · Answer 3 · answered Dec 19 '15 at 05:35

try this .. replace the code with your mainactivity_layout.xml

<RelativeLayout xmlns:android="http://schemas.android.com/apk/re/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:id="@+id/friendtilefragment"
android:paddingBottom="@dimen/activity_vertical_margin"
tools:context=".MainActivity">

<android.support.v4.widget.SwipeRefreshLayout
android:id="@+id/swipe_refresh_layout"
android:layout_width="match_parent"
android:layout_height="wrap_content">

<ListView
android:id="@+id/list"
android:layout_width="fill_parent"
android:layout_height="wrap_content" 
android:divider="@color/list_divider"
android:dividerHeight="1dp"
android:listSelector="@drawable/list_row_selector" />    
</android.support.v4.widget.SwipeRefreshLayout>
</RelativeLayout>

I Hope this works..

Unable to start fragment from onListItemClick

3 Answers3