How do I make the slugs work in django

Question

I have followed the basic polls tutorial and I have tried to modify it to make it work for slugs but it's not working. I went from this in my views.py

def detail(request, article_id):
    details = "blog/detail.html"
    context = {
        "article": get_object_or_404(Article, pk=article_id)
    }
    return render(request, details, context)

and

url(r'^(?P<article_id>[0-9]+)/$', views.detail, name='detail'),

to this in my views.py

def detail(request, slug):
    details = "blog/detail.html"
    context = {
        "article": get_object_or_404(Article, slug)
    }
    return render(request, details, context)

and

url(r'^(?P<slug>[\w-]+)/$', views.detail, name='detail'),

this is my models.py

from django.db import models

from django.contrib.auth.models import User



class Article(models.Model):
    author = models.ForeignKey(User)
    title = models.CharField(max_length=250)
    slug = models.SlugField()
    body = models.TextField()
    created = models.DateTimeField(auto_now=True)

    def __str__(self):
        return self.title

this is my admin.py

from django.contrib import admin

from .models import Article


@admin.register(Article)
class ArticleAdmin(admin.ModelAdmin):
    prepopulated_fields = {"slug": ("title",)}

but it's not working. How Do I get the slugs to show in my url

the tutorial is the django tutorial on the site. part 3 where they demonstrate how to displayt the article id. but instead of the id I want to display the slug — losee, Dec 25 '15 at 18:10
@losee: I cannot find any model named `Article` in the tutorial — Andrea Corbellini, Dec 25 '15 at 18:12
@AndreaCorbellini: and I can't find any reference to any slug field either. — Saturnix, Dec 25 '15 at 18:13
@AndreaCorbellini I modified it to fit my model which is named article. The model they are using is called question — losee, Dec 25 '15 at 18:15
OK, but please show us your code. As @Saturnix said, the `Question` in the tutorial does not support slugs. We can't guess what you have done — Andrea Corbellini, Dec 25 '15 at 18:19
@AndreaCorbelliniI edited it. If you need more code let me know what else — losee, Dec 25 '15 at 18:28
**Tip:** add `unique=True` and `db_index=True` to your `SlugField` in order to make your models safe and fast. — Andrea Corbellini, Dec 25 '15 at 18:48
@losee Using `slug` prepopulated from `title` means that no 2 articles should have the same title for urls to map uniquely to a single `Article` object. — Rahul Gupta, Dec 25 '15 at 18:51
@losee Checkout this question: http://stackoverflow.com/questions/837828/how-do-i-create-a-slug-in-django — narendra-choudhary, Dec 25 '15 at 19:37

Rahul Gupta · Answer 1 · 2015-12-25T18:54:15.893

In your views, you need to pass slug argument.

def detail(request, slug):
    details = "blog/detail.html"
    context = {
        "article": get_object_or_404(Article, slug=slug) # pass slug 
    }
    return render(request, details, context)

If you are creating Articles using admin, then the slug will get prepopulated using title field. But, if you want to create an article other than doing it in admin, you need to call slugify() function explicitly in your model's save() and assign it to the article object before saving it.

You can do something like:

class Article(models.Model):

    def save(self, *args, **kwargs):
        self.slug = slugify(self.title) # set the slug explicitly
        super(Article, self).save(*args, **kwargs) # call Django's save()

Note: Since you are using slug instead of id for detail view, this means that no 2 articles should have the same slug i.e. the same title. Add unique=True constraint in your model for handling this.

I tried that. where is the documentation on how to use slugs in django — losee, Dec 25 '15 at 20:18
Check this doc link on `SlugField` https://docs.djangoproject.com/en/1.9/ref/models/fields/#slugfield — Rahul Gupta, Dec 25 '15 at 20:23

score 1 · Answer 2 · edited May 23 '17 at 12:17

1

You're missing the parameter name in get_object_or_404. Assuming that your Article model has a SlugField named slug:

get_object_or_404(Article, slug=slug)

EDIT: User update the question providing the model. This part is no longer needed.

Since you didn't posted your Article model, I'm gonna provide an example of how you should code it to make it compatible with my example:

from django.utils.text import slugify
from django.db import models

class Article(models.model):
    #…
    slug = models.SlugField(unique=True)

    def save(self, *args, **kwargs):
        self.slug = slugify(self.slug)
        super(Article, self).save(*args, **kwargs)

Copied from this answer. Notice how we override the save method to automatically generate the slug. Might not be a good idea depending on your architecture. I'd recommend to call slugify in a view or in a modelform like in this tutorial.

edited May 23 '17 at 12:17

Community

1
1

answered Dec 25 '15 at 18:07

Saturnix

10,130
17
64
120

There are some inconsistencies: `reference_slug` vs `slug` vs `s`. Also, I think you wanted to write `slugify(self.title)` or something like that, instead of `slugify(self.slug)` (what's the point of making a slug out of a slug?) – Andrea Corbellini Dec 25 '15 at 18:23
@Saturnix your code doesn't work. I've posted my model as well – losee Dec 25 '15 at 18:46
@Andrea Corbellini: Very simple: SlugField doesn't automatically slugify your text. SlugField works exactly like a CharField. Ioose: code has been updated considering your newly updated question. – Saturnix Dec 25 '15 at 18:46
@Saturnix this is the error I get using your answer Reverse for 'detail' with arguments '(1,)' and keyword arguments '{}' not found. 1 pattern(s) tried: ['blog/(?P[-\\m]+)/$'] – losee Dec 25 '15 at 18:55
the url I see in this error (`['blog/(?P[-\\m]+)/$']`) is different from the one I see in your urls.py – Saturnix Dec 25 '15 at 18:56

How do I make the slugs work in django

2 Answers2

Linked