Trying to create Search Bar via PHP & MySQL

Question

Below is the HTML:

<body>
<p>Search</p>
<form name="form1" method="post" action="searchresults.php">
<input name="search" type="text" size="40" maxlength="50">
<input type="submit" name="Submit" value="search">

</form>
</body>

Below is the PHP:

<?php
    require_once '../database/config.php';

    if(!isset($_POST['search'])) {
        header("Location: ads.index.php");
    }
    $search_sql="SELECT * FROM posts WHERE title LIKE '%" .$_POST['search']."%' OR description LIKE '%".$_POST['search']."%'";
    $result = $dbc->query($search_sql);
    if(mysql_num_rows($result)!=0) {    
    $search_rs=mysql_fetch_assoc($result);
    }

    ?>
    <p>Search Results</p>
    <?php if(mysql_num_rows($result)!=0) {
        do { ?>
    <p><?php echo $search_rs['name']; ?></p>
    <?php   } while ($search_rs=mysql_fetch_assoc($result));
    } else {
        echo "No results found";
    } 
    ?>

What is wrong here? I keep getting an error when trying to search in the database - it says the mysql_num_rows function is deprecated, I don't understand how to replace it.

Thank you

Yes, `mysql_*` functions are deprecated and you should not use them. — Praveen Kumar Purushothaman, Dec 29 '15 at 18:52

score 0 · Accepted Answer · edited May 23 '17 at 12:23

0

Please change your $dbc to use the latest one, either mysqli_* or PDO will do. For now, changing your code:

<?php
  require_once '../database/config.php';

  if (!isset($_POST['search']))
    header("Location: ads.index.php");

  // create the connection object
  $conn = mysqli_connect(DB_HOST, DB_USER, DB_PASS, DB_NAME);
  // Don't forget to sanitize your user queries.
  // Here $conn is the connection object I assume. Replace it with yours.
  $_POST['search'] = mysqli_real_escape_string($conn, $_POST['search']);
  $search_sql = "SELECT * FROM `posts` WHERE `title` LIKE '%" . $_POST['search'] . "%' OR `description` LIKE '%".$_POST['search']."%'";
  // change the result here.
  $result = mysqli_query($conn, $search_sql);
  if(mysqli_num_rows($result) > 0) {    
    $search_rs = mysqli_fetch_assoc($result);
  }

  ?>
  <p>Search Results</p>
  <?php
  if (mysqli_num_rows($result) > 0) {
    do { ?>
      <p><?php echo $search_rs['name']; ?></p>
  <?php
    // Kindly note, how false and assignment is used here.
    } while (false != ($search_rs = mysqli_fetch_assoc($result)));
  }
  else
    echo "No results found";
?>

If you are interested, there's also an open source project Converting to MySQLi in GitHub.

And regarding more information about why you shouldn't use mysql_* functions, read Why shouldn't I use mysql_* functions in PHP?

edited May 23 '17 at 12:23

Community

1
1

answered Dec 29 '15 at 18:57

Praveen Kumar Purushothaman

164,888
24
203
252

$conn - Undefined variable mysqli_real_escape_string() - expects parameter 1 to be mysqli, null given mysqli_num_rows() - expects paramteter 1 to be mysqli_result – sshaikh210 Dec 29 '15 at 19:01
@sshaikh210 **Did you read my comments or blindly copied it without reading? `// Here $conn is the connection object I assume. Replace it with yours.`** – Praveen Kumar Purushothaman Dec 29 '15 at 19:02
And also @sshaikh210, **Please change your `$dbc` to use the latest one.** – Praveen Kumar Purushothaman Dec 29 '15 at 19:04
I copied, what do I replace it for? – sshaikh210 Dec 29 '15 at 19:04
@sshaikh210 Kindly share how you get your `$dbc`. Please provide the source of `'../database/config.php'`. – Praveen Kumar Purushothaman Dec 29 '15 at 19:04
$dbc = new PDO('mysql:host=' . DB_HOST . ';dbname=' . DB_NAME . '','' . DB_USER . '','' . DB_PASS . ''); $dbc->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); – sshaikh210 Dec 29 '15 at 19:05
@sshaikh210 Kindly [edit](http://stackoverflow.com/posts/34517166/edit) the post and update. But it looks like you are already using PDO. Why are you using `mysql_*` functions with PDO? – Praveen Kumar Purushothaman Dec 29 '15 at 19:06
Also I don't believe I have MySQLi installed - Do you know how to replace it with PDO_MySQL? – sshaikh210 Dec 29 '15 at 19:07
@sshaikh210 No I don't know. I believe you have **MySQLi** installed. Because it comes bundled. Try using `phpinfo();` and check if you have `mysqli_*` installed. – Praveen Kumar Purushothaman Dec 29 '15 at 19:08
@sshaikh210 I have updated my code. Kindly copy and paste and tell me if you get any errors. – Praveen Kumar Purushothaman Dec 29 '15 at 19:09
Thanks so much, this is the last error I am getting: mysqli_num_rows() expects parameter 1 to be mysqli_result – sshaikh210 Dec 29 '15 at 19:13
@sshaikh210 Updated answer. – Praveen Kumar Purushothaman Dec 29 '15 at 19:15
Multiple - Undefined index: name in - errors on Line 24 "
" – sshaikh210 Dec 29 '15 at 19:18
@sshaikh210 Try giving `$search_rs[0];` or `$search_rs[1];` until you get the right result. Change `mysqli_fetch_assoc($result)` to `mysqli_fetch_array($result)`, please? – Praveen Kumar Purushothaman Dec 29 '15 at 19:19
@sshaikh210 Did it work? – Praveen Kumar Purushothaman Dec 29 '15 at 19:22
Can you explain to me what that means? $search_rs[0] or [1]? What does the incremented numbers do for the variable? – sshaikh210 Dec 29 '15 at 19:24
@sshaikh210 Not associative, but by column index. – Praveen Kumar Purushothaman Dec 29 '15 at 19:24
Thanks for the help, its producing some things correctly - when I search for something not in the database it produces the right result "No results found" but when I search for something in the database it does not produce the row correctly. – sshaikh210 Dec 29 '15 at 19:28
@sshaikh210 What's wrong? What do you mean by "it does not produce the row correctly"? – Praveen Kumar Purushothaman Dec 29 '15 at 19:29
1

Fixed it, thanks so much Praveen! – sshaikh210 Dec 29 '15 at 19:47
@sshaikh210 Happy Holidays. Enjoy! – Praveen Kumar Purushothaman Dec 29 '15 at 19:51

Trying to create Search Bar via PHP & MySQL

1 Answers1