I'm getting errors in my shell script

Question

MY CODE :

echo "Please Enter The Purchase Price : "
read $PurPrice
echo "Please Enter The Selling Price : "
read $SellPrice

if [ "$PurPrice" -eq "$SellPrice" ]
        then
                echo "No Profit No Loss !"

elif [ "$PurPrice" -gt "$SellPrice" ]
        then
                loss=echo "$pp - $sp" | bc -l
                echo "There is loss of $loss."
else
        profit=echo "$sp - $pp" | bc -l
        echo "There is Profit $profit. "
fi

THE ERRORS :

Please Enter The Purchase Price :                                                                                                 
': not a valid identifier `                                                                                                       
Please Enter The Selling Price :                                                                                                  
': not a valid identifier `                                                                                                         
    Newfile.sh: line 5: $'\r': command not found                                                                                      
    Newfile.sh: line 10: syntax error near unexpected token `elif'                                                                    
    'ewfile.sh: line 10: elif [ "$PurPrice" -gt "$SellPrice" ]

Possible duplicate of [Why is a shell script giving syntax errors when the same code works elsewhere?](http://stackoverflow.com/questions/31886144/why-is-a-shell-script-giving-syntax-errors-when-the-same-code-works-elsewhere) — Thomas Dickey, Dec 30 '15 at 21:45
Possible duplicate of (or at least, the same problem as) [Assign curl output to variable in bash](http://stackoverflow.com/questions/8737638/assign-curl-output-to-variable-in-bash) — ghoti, Dec 30 '15 at 21:52
DOS line-endings are a problem but so is using `$` in the `read` commands. — Etan Reisner, Dec 30 '15 at 21:55
On both of your "read" lines, you do not need the "$" symbol. "$" is used when you want the value of a variable. — IT_User, Dec 30 '15 at 21:56

John Hascall · Accepted Answer · 2015-12-30T21:53:06.643

2

Your code has lots of issues.

You were not consistent in your variable names (e.g. pp vs. PurPrice)
You only use $ when you want the value of a variable (not on read's for example).
You can't use strings with the integer test operators (-eq and so on).
You need backticks to get the output of commands you run.

Here is functional code:

#!/bin/sh
echo "Please Enter The Purchase Price : "
read PurPrice

echo "Please Enter The Selling Price : "
read SellPrice

if [ $PurPrice -eq $SellPrice ] ; then
        echo "No Profit No Loss !"
elif [ $PurPrice -gt $SellPrice ] ; then
        loss=`echo "$PurPrice - $SellPrice" | bc -l`
        echo "There is loss of $loss."
else
        profit=`echo "$SellPrice - $PurPrice" | bc -l`
        echo "There is Profit $profit. "
fi

but note that the test operators (-eq -gt etc) only work on integers (entering a price like 1.99 will cause it to fail)!

edited Dec 30 '15 at 21:53

answered Dec 30 '15 at 21:47

John Hascall

9,176
6
48
72

1

Here's a fun solution to the "only works on integers" problem: http://stackoverflow.com/a/33759747/1072112 – ghoti Dec 30 '15 at 21:55
1

Quoting the variables in `test`/`[` contexts is important. – Etan Reisner Dec 30 '15 at 21:55
How to get the floating Value ?? – AndroPanther786 Dec 30 '15 at 21:57

I'm getting errors in my shell script

1 Answers1