171

I'm trying to run a script during my building process in my Dockerfile, but it doesn't seems to work.

I tried that way:

FROM php:7-fpm
ADD bootstrap.sh /
ENTRYPOINT ["/bin/bash", "/bootstrap.sh"]

Also this way:

FROM php:7-fpm    
ADD bootstrap.sh /
RUN bash -c "/bootstrap.sh"

And also by executing my running container:

docker exec symfony /bin/bash -c "/bootstrap.sh"

Nothing seems to work.

Do you know how to do it?

John Smith
  • 7,243
  • 6
  • 49
  • 61
Kevin
  • 4,823
  • 6
  • 36
  • 70

6 Answers6

209

RUN and ENTRYPOINT are two different ways to execute a script.

RUN means it creates an intermediate container, runs the script and freeze the new state of that container in a new intermediate image. The script won't be run after that: your final image is supposed to reflect the result of that script.

ENTRYPOINT means your image (which has not executed the script yet) will create a container, and runs that script.

In both cases, the script needs to be added, and a RUN chmod +x /bootstrap.sh is a good idea.

It should also start with a shebang (like #!/bin/sh)

Considering your script (bootstrap.sh: a couple of git config --global commands), it would be best to RUN that script once in your Dockerfile, but making sure to use the right user (the global git config file is %HOME%/.gitconfig, which by default is the /root one)

Add to your Dockerfile:

RUN /bootstrap.sh

Then, when running a container, check the content of /root/.gitconfig to confirm the script was run.

Francis Chartrand
  • 167
  • 1
  • 1
  • 15
VonC
  • 1,262,500
  • 529
  • 4,410
  • 5,250
59

In addition to the answers above:

If you created/edited your .sh script file in Windows, make sure it was saved with line ending in Unix format. By default many editors in Windows will convert Unix line endings to Windows format and Linux will not recognize shebang (#!/bin/sh) at the beginning of the file. So Linux will produce the error message like if there is no shebang.

Tips:

  • If you use Notepad++, you need to click "Edit/EOL Conversion/UNIX (LF)"
  • If you use Visual Studio, I would suggest installing "End Of Line" plugin. Then you can make line endings visible by pressing Ctrl-R, Ctrl-W. And to set Linux style endings you can press Ctrl-R, Ctrl-L. For Windows style, press Ctrl-R, Ctrl-C.
VeganHunter
  • 5,584
  • 2
  • 26
  • 26
  • 1
    My VSCode had automatically set a shell script's lined endings to CRLF in windows. The docker build was failing because of some random characters. I changed the settings in VS Code and it immediately started to work. Thanks! I've upvoted. – Adithya Upadhya Sep 06 '19 at 01:33
  • on Windows git checks out by default with CR+LF, and this causes the issue for shell scripts when docker image is created, so your answer is really helpful! – AntonK Feb 18 '22 at 13:17
  • 1
    Tip: Better give an extension to the scripts you are going to run from docker (e.g. `.sh`) and add a `.gitattributes` file to your `git` repo root with the following content: `*.sh text eol=lf`. Then you don't need to worry about newlines. – Marinos An Dec 19 '22 at 10:16
  • @MarinosAn , good advice, though it will not stop a text editor placing wrong ending when you edit the file. But, I agree, it is good to have that git setting anyway. – VeganHunter Dec 21 '22 at 02:02
28

Try to create script with ADD command and specification of working directory Like this("script" is the name of script and /root/script.sh is where you want it in the container, it can be different path:

ADD script.sh /root/script.sh

In this case ADD has to come before CMD, if you have one BTW it's cool way to import scripts to any location in container from host machine

In CMD place [./script]

It should automatically execute your script

You can also specify WORKDIR as /root, then you'l be automatically placed in root, upon starting a container

Michael
  • 415
  • 5
  • 12
21

It's best practice to use COPY instead of ADD when you're copying from the local file system to the image. Also, I'd recommend creating a sub-folder to place your content into. If nothing else, it keeps things tidy. Make sure you mark the script as executable using chmod.

Here, I am creating a scripts sub-folder to place my script into and run it from:

RUN mkdir -p /scripts
COPY script.sh /scripts
WORKDIR /scripts
RUN chmod +x script.sh
RUN ./script.sh
rayryeng
  • 102,964
  • 22
  • 184
  • 193
ldobson
  • 387
  • 2
  • 5
4
WORKDIR /scripts
COPY bootstrap.sh .
RUN ./bootstrap.sh 
Danwand N S
  • 172
  • 1
  • 10
Anthony Awuley
  • 3,455
  • 30
  • 20
4

For running a bash script when during container creation:

Make script.sh file:

#!/bin/bash
you commands

If you are using windows, you must change script.sh file convention. To do this, in Notepad++, go to Edit -> EOL Conversion -> Change from CRLF to LF, and your bash file will be valid for execution.

If you are using an Alpine image, you must use #!/bin/sh instead of #!/bin/bash in the first line of your bash file.

Then, in your Dockerfile, copy your bash file to your image, and use the ENTRYPOINT instruction for running the file when container is being created:

COPY script.sh /
RUN chmod +x /script.sh
ENTRYPOINT ["/script.sh"]

Notice that the ENTRYPOINT instruction uses the location of the bash file you copied into your image.

now when you create a container, script.sh file will execute.

Lee Goddard
  • 10,680
  • 4
  • 46
  • 63
sajjad pld
  • 61
  • 3
  • 1
    "notice: if you are using an alpine image, you must use #!/bin/sh`` instead of #!/bin/bash``` in the first line of your bash file.". Nice catch. Thank you – Benny Jan 03 '23 at 15:15