Form Not Saving to PHP File

Question

I have the following code. This is used on my admin panel for administrators to put their notes in so the other admins can read it. I don't want to store this in a database.

The issue is the form is not saving the text in the textarea.

<?php
IF (ISSET($_POST["submit"])) {
$string = '<?php 
$notes = "'. $_POST["notes"]. '";
?>';

$fp = FOPEN("includes/notes.php", "w");
FWRITE($fp, $string);
FCLOSE($fp);
echo '<div class="ok">' . $lang["done"] . '</div>';
}

include("includes/notes.php");
?>
<form action="" method="post" id="notesform">
<textarea placeholder="Admin notes" class="notes" id="notes"><?php echo $notes; ?></textarea>
<input type="submit" value="OK">
</form>

What is going wrong? How can I fix this? I have tried most suggestions on Google but it keeps happening!

Change `` to `` then you first IF test will actually find the button name in `$_POST` — RiggsFolly, Jan 06 '16 at 12:18
BTW: it is horrible to write the functions etc, in camelcase. Hard to read for other developers who could join your team etc.Think about it. — B001ᛦ, Jan 06 '16 at 12:47
@bub That's true, not all my code is uppercase. I took this script from the interwebs, that's why. I will convert it to lowercase, though. Thanks for your suggestion! — John Doe, Jan 06 '16 at 13:50

Pupil · Accepted Answer · 2016-01-06T12:26:38.067

3

You did not give name attribute to submit button.

When we submit a form to PHP, only elements get posted with a name attribute.

So, your code is not entering:

IF (ISSET($_POST["submit"])) { // Not satisfying this condition.

Corrected code:

<input type="submit" value="OK" name="submit">

Apply the same for text area also.

edited Jan 06 '16 at 12:26

answered Jan 06 '16 at 12:12

Pupil

23,834
6
44
66

Ooooh of course! I tried adding that earlier to the `form` tag, but that didn't work. Thanks for your help! – John Doe Jan 06 '16 at 12:15
@Pupil, is it possible here to get the text-area value without giving name="notes"? – Amit Rajput Jan 06 '16 at 12:24
Yes, @AmitRajput, you are correct. I will correct my answer. Thanks for the catch. – Pupil Jan 06 '16 at 12:26
Thanks...cheers!!! :-) – Amit Rajput Jan 06 '16 at 12:29

score 2 · Answer 2 · answered Jan 06 '16 at 12:17

2

You had not given name="notes" to text-area and submit button name. Here is the complete correct code. Try this:

<?php
IF (ISSET($_POST["submit"])) {
$string = $_POST["notes"];

$fp = FOPEN("includes/notes.php", "w");
FWRITE($fp, $string);
FCLOSE($fp);
echo '<div class="ok">' . $lang["done"] . '</div>';
}

include("includes/notes.php");
?>
<form action="" method="post" id="notesform">
<textarea placeholder="Admin notes" class="notes" name="notes" id="notes"><?php echo $notes; ?></textarea>
<input type="submit" name="submit" value="OK">
</form>

answered Jan 06 '16 at 12:17

Amit Rajput

2,061
1
9
27

@john is it works for you? – Amit Rajput Jan 06 '16 at 12:21
Yes, I got it working now, the guy above you was a little faster. Thanks for your help, though. It's appreciated – John Doe Jan 06 '16 at 12:25
Thanks...cheers!!! :-) – Amit Rajput Jan 06 '16 at 12:29

Form Not Saving to PHP File

2 Answers2