DELETE FROM table WHERE IN() prepared statement deletes only the first value of array

Question

through ajax you get an array for $_POST.

This is my code.

<?php
include 'connect.php';
$deletethesestring = '';
foreach ($_POST as $v)
{

    $deletethesestring .= $v.',';

}

$deletethesestring  = rtrim($deletethesestring ,',');

echo $deletethesestring;



$deleteprizesqry = $pdo->prepare('DELETE FROM tbname where tbname_id IN(:deletethesestring);');
$deleteprizesqry  -> bindParam(':deletethesestring', $deletethesestring);

$deleteprizesqry->execute();
?>

if my array is for example [9,7,3,4,8,5] my code only deletes 9. and the rest still stay. I want it to delete every row whose id belongs in the array. how do i do this?

@TimBiegeleisen int(10) It deletes the first value in the array though. which would be 9 in my example while the other rows stay(not deleted). — Johanna Cristine Dy, Jan 08 '16 at 05:22
This is not the answer. I have a suggestion for your code. Dont complicate the code. Just use implode to split the array to coma separated string. `implode(',', $_POST)`. In this case you dont need to use any other functions like trim. — akhilp2255, Jan 08 '16 at 05:23
have a look at http://stackoverflow.com/questions/920353/can-i-bind-an-array-to-an-in-condition — Chetan Ameta, Jan 08 '16 at 05:23
You're not putting quotes around the list of numbers, which appears to be correct. — Tim Biegeleisen, Jan 08 '16 at 05:23
Check this http://stackoverflow.com/questions/2373562/pdo-with-where-in-queries — Saty, Jan 08 '16 at 05:24
You can solve this by make small changes, check posted answer. — AddWeb Solution Pvt Ltd, Jan 08 '16 at 05:40

AddWeb Solution Pvt Ltd · Accepted Answer · 2016-01-08T06:40:06.263

3

Please try below code:

<?php
include 'connect.php';
$deletethesestring = '';
foreach ($_POST as $v)
{

    $deletethesestring .= $v.',';

}

$deleteIds  = rtrim($deletethesestring ,',');

$deletethesestring = join(',', array_fill(0, count($_POST), '?'));

$delQry = "DELETE FROM tbname where tbname_id IN($deletethesestring)";
$deleteprizesqry = $pdo->prepare($delQry);
$deleteprizesqry->execute($_POST);

Hope this help you well!

edited Jan 08 '16 at 06:40

answered Jan 08 '16 at 05:37

AddWeb Solution Pvt Ltd

21,025
5
26
57

thanks. I just added +1 to count($deletethesestring) then used $_POST in execute instead of $deleteIds. – Johanna Cristine Dy Jan 08 '16 at 05:50
actually.. count($deletethesestring) should be count($_POST) afterall. – Johanna Cristine Dy Jan 08 '16 at 06:04
and we don't need the foreach part anymore :D – Johanna Cristine Dy Jan 08 '16 at 12:38

DELETE FROM table WHERE IN() prepared statement deletes only the first value of array

1 Answers1