39

If I create a swift struct with no init, then I can call the compiler-generated default memberwise initialiser, like so:

struct OrderFill {
    let price:Int
    let qty: Int
    let timeStamp: NSDate
}
let o = OrderFill(price: 2, qty: 1, timeStamp: someDate)

What I'd like to do is create a convenience init method to deserialise from a dictionary, which then chains to the default memberwise init. Something like

struct OrderFill {
    let price:Int
    let qty: Int
    let timeStamp: NSDate

    init(dict:[String:AnyObject]) throws {
        self.init(
            price: dict["price"] as! Int
            qty: dict["qty"] as! Int
            timeStamp: try parseDate(dict["ts"] as! String)
    }
}
let o = OrderFill(someDict)

When I try write this code though, the compiler (Xcode 7.2) gives me the error "Extra argument 'qty' in call" as though it doesn't see the default memberwise and is trying to recursively call init(dictionary)

I can write my own memberwise init, or I can simply assign the properties directly from my init(dictionary), but it'd be nice if I could chain the call. Is there any way to do this in swift?

Orion Edwards
  • 121,657
  • 64
  • 239
  • 328

2 Answers2

93

Add your own initializer as an extension to your struct. Extensions cannot remove existing functionalities, so it will preserve struct's default initializer.

struct OrderFill {
    let price: Int
    let qty: Int
    let timeStamp: NSDate
}

extension OrderFill {

    init(dict: [String: AnyObject]) throws {
        self.init(
            price: dict["price"] as! Int,
            qty: dict["qty"] as! Int,
            timeStamp: try parseDate(dict["ts"] as! String)
        )
    }
}

let o = OrderFill(someDict)
Sebastian Osiński
  • 2,894
  • 3
  • 22
  • 34
  • 13
    May seem hacky, but it's also in the book... ```NOTE If you want your custom value type to be initializable with the default initializer and memberwise initializer, and also with your own custom initializers, write your custom initializers in an extension rather than as part of the value type’s original implementation. For more information, see Extensions.``` – rob5408 Oct 22 '17 at 02:25
  • 1
    This is totally strange, it works in extension but not in the struct itself. What is the logic behind it? – khunshan May 21 '19 at 20:27
9

From the apple docs about Initialization:

Structure types automatically receive a memberwise initializer if they do not define any of their own custom initializers

and

Note that if you define a custom initializer for a value type, you will no longer have access to the default initializer (or the memberwise initializer, if it is a structure) for that type. This constraint prevents a situation in which additional essential setup provided in a more complex initializer is circumvented by someone accidentally using one of the automatic initializers instead.

Therefore the answer is NO. You cannot provide a custom initializer and use the memberwise initializer at the same time.

It sounds like this swift evolution proposal talks about extending the capabilities of the current memberwise initializer. But of course that is not out yet, you can however still take a look to learn a bit about what the limitations of the current situation are.

luk2302
  • 55,258
  • 23
  • 97
  • 137
  • Custom initializers alongside the default memberwise initializers are now possible. Just put the custom initalizer in an extension: https://www.hackingwithswift.com/example-code/language/how-to-add-a-custom-initializer-to-a-struct-without-losing-its-memberwise-initializer – user339946 Jul 25 '21 at 20:33