on-click checked/unchecked works for 2 times only then not working

Question

set check working for two time only.
->once it checked -> then unchecked
but i want this something like toggle. please fix this code.

$('#a').click(function() {
  if ($("#radioinstant").is(':checked')) {
$("#radioinstant").removeAttr('checked', 'checked'); //This line
}else{
$("#radioinstant").attr('checked', 'unchecked');
}

});

<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>
<div>
    With JQuery Function: <input type="checkbox" id="radioinstant"/>
    <a id="a" href="#">set check</a>
</div>

thanks in advance

score 1 · Accepted Answer · answered Jan 13 '16 at 08:45

1

You can simplify the logic by providing a function to the prop() class which inverts the current setting. Try this:

$('#a').click(function() {
  $("#radioinstant").prop('checked', function(i, checked) {
    return !checked;
  });
});

<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>
<div>
  With JQuery Function:
  <input type="checkbox" id="radioinstant" />
  <a id="a" href="#">set check</a>
</div>

answered Jan 13 '16 at 08:45

Rory McCrossan

331,213
40
305
339

awesome its working :) – Gautam Jha Jan 13 '16 at 08:50
This would also work $('#a').click(function() { $("#radioinstant").prop('checked',!$("#radioinstant").is(":checked")); }); – Anoop Joshi P Jan 13 '16 at 08:52
1

That would work, but it makes two queries to the DOM to get the `#radioinstant` element. The method in my answer only makes 1 DOM query. – Rory McCrossan Jan 13 '16 at 09:18

on-click checked/unchecked works for 2 times only then not working

1 Answers1