Why doesn't my edittext change it content?

Question

I want to change the content of the edittext megapixel to be the product of the width and height text boxes to make a megapixel calculator.

public void calculate()
{

    EditText tb_widthpx = (EditText) findViewById(R.id.txtbox_widthpx);
    EditText tb_heightpx = (EditText)findViewById(R.id.txtbox_heigthpx);
    EditText tb_megapixel = (EditText) findViewById(R.id.txtbox_megapixel);

    if (tb_widthpx.getText().toString() != "" && tb_heightpx.getText().toString() !="")
    {
        int produkt;
        int width = Integer.parseInt(tb_widthpx.getText().toString());
        int height = Integer.parseInt((tb_heightpx.getText().toString()));

        produkt = width * height;
        tb_megapixel.setText(String.valueOf(produkt));
    }

score 1 · Accepted Answer · edited May 23 '17 at 11:59

1

In Java you have to use .equals() so try this,

public void calculate()
{

    EditText tb_widthpx = (EditText) findViewById(R.id.txtbox_widthpx);
    EditText tb_heightpx = (EditText)findViewById(R.id.txtbox_heigthpx);
    EditText tb_megapixel = (EditText) findViewById(R.id.txtbox_megapixel);

    if (!tb_widthpx.getText().toString().equals("") && !tb_heightpx.getText().toString().equals(""))
    {
        int produkt;
        int width = Integer.parseInt(tb_widthpx.getText().toString());
        int height = Integer.parseInt((tb_heightpx.getText().toString()));

        produkt = width * height;
        tb_megapixel.setText(String.valueOf(produkt));
    }

Reference: Why you use .equals()

edited May 23 '17 at 11:59

Community

1
1

answered Jan 13 '16 at 22:58

Gary Holiday

3,297
3
31
72

However this still doesnt solve my original problem but thanks for the remark. – Vortek Jan 14 '16 at 09:34
I just solved it on my own. I idiot didn't connect the onclick to the button. Sorry. – Vortek Jan 14 '16 at 09:45

score 0 · Answer 2 · answered Jan 13 '16 at 23:05

You can use .equals() to compare Strings. Like this:

if (!tb_widthpx.getText().toString().equals("") && !tb_heightpx.getText().toString().equals("")) {
    int produkt;
    int width = Integer.parseInt(tb_widthpx.getText().toString());
    int height = Integer.parseInt((tb_heightpx.getText().toString()));

    produkt = width * height;
    tb_megapixel.setText(String.valueOf(produkt));
}

But for a better performance you should use .length(). Like this:

if (!tb_widthpx.getText().toString().length() == 0 && !tb_heightpx.getText().toString().length() == 0) {
    int produkt;
    int width = Integer.parseInt(tb_widthpx.getText().toString());
    int height = Integer.parseInt((tb_heightpx.getText().toString()));

    produkt = width * height;
    tb_megapixel.setText(String.valueOf(produkt));
}

I just solved it on my own. I idiot didn't connect the onclick to the button. Sorry. — Vortek, Jan 14 '16 at 09:46

Why doesn't my edittext change it content?

2 Answers2