PHP PDO bindValue does not update the DB

Question

Could someone tell me what I am doing wrong.

If I use the code below, I am able to update the DB.

            $sUpdateSql = "UPDATE googleAnalytics SET $period = '$value' WHERE statisticName = '$item' ";
            $preparedStatement = $db->query($sUpdateSql);

However, with the statement below the DB does not update.

            $sUpdateSql = "UPDATE googleAnalytics SET $period = '?' WHERE statisticName = '?' ";
            $preparedStatement = $db->prepare($sUpdateSql);
            /* bind parameters for markers */
            $preparedStatement->bindValue(1, $value);
            $preparedStatement->bindValue(2, $item);
            $preparedStatement->execute();

Aren't both statements PDO? Only one binds the parameters and the other doesn't. — tadalendas, Jan 14 '16 at 13:43
http://php.net/manual/en/pdo.error-handling.php would have helped you here. — Funk Forty Niner, Jan 14 '16 at 13:49

score 3 · Accepted Answer · answered Jan 14 '16 at 13:44

3

Remove the single quotes around the question marks.

bindValue handles escaping the strings.

Just an FYI, you can also name your params.

"SELECT * FROM foo WHERE id = :id"

bindValue('id', $id);

answered Jan 14 '16 at 13:44

MajorCaiger

1,893
1
12
18

PHP PDO bindValue does not update the DB

1 Answers1