Find when the upload is over

Question

I have got several files in folder which I want to upload them to my server. All files are uploaded in the same time. What I want to find is when the last file is uploaded in my server. My code is the following:

public void UploadFile()
{   
    // Only get subdirectories that begin with the letter "p."
    string[] dirs = Directory.GetFiles(path+ dataDir);
    int counter = 1;

    foreach (string dir in dirs) {

        try{
            // Get an instance of WebClient
            WebClient client = new System.Net.WebClient();
            //client.UploadProgressChanged += WebClientUploadProgressChanged;
            client.UploadFileCompleted += WebClientUploadCompleted;
            // parse the ftp host and file into a uri path for the upload
            Uri uri = new Uri(m_FtpHost + new FileInfo(dir).Name);
            // set the username and password for the FTP server
            client.Credentials = new System.Net.NetworkCredential(m_FtpUsername, m_FtpPassword);
            // upload the file asynchronously, non-blocking.
            client.UploadFileAsync(uri, "STOR",dir); 
        }
        catch(Exception e){
            print(e.Message);
        }
    }

}

void WebClientUploadCompleted(object sender, UploadFileCompletedEventArgs e)
{
    print( "Upload is finished. ");
}

As it is right now UploadFileCompleted is called for every file seperately However I want to have a flag when all files are uploaded. How can I do so?

You could use `UploadFileTaskAsync` instead and then just wait on all the returned tasks to finish. — juharr, Jan 20 '16 at 13:49
Use a backgroundworker as explained [in this post](http://stackoverflow.com/a/5483644/4746087) — Kurt Van den Branden, Jan 20 '16 at 13:53
Put flag in method that called UploadFile when all files are sent. Why do you need an async event when the uploads complete? — jdweng, Jan 20 '16 at 13:54

score 1 · Accepted Answer · answered Jan 20 '16 at 13:56

You can simply use the private "totalUploadCounter" var to check when all uploads are finished:

private int totalUploadCounter = 0;
private int counter = 0;
public void UploadFile()
{ 
  string[] dirs = Directory.GetFiles(path + dataDir); 
  totalUploadCounter = 0;
  counter = 0;
  foreach (var dir in dirs) {
    totalUploadCounter += Directory.GetFiles(dir).Length;
  }

  // your upload code here
 }

void WebClientUploadCompleted(object sender, UploadFileCompletedEventArgs e)
{
    counter++;
    if (counter == totalUploadCounter) {
      // ALL UPLOADS FINISHED!!!
    }
}

I'm wondering whether this solution has "data race" issue. See here: https://docs.oracle.com/cd/E19205-01/820-0619/geojs/index.html — Christopher, Aug 03 '17 at 04:08

Find when the upload is over

1 Answers1