get wrong id after dbliclick - eventlistener

Question

i create an table with createElement. The table, tr and td get an id. Every td gets an dblclick eventlistener. So when you do an dblick a div will be shown.

but i get back the wrong id. I get only the id of the last entry.

I check the entry in the debugg mode,it's ok, why i get only the last id?

i want to get the id of the element, when i do a dblclick.

Insert Function:

countTable ++;

document.getElementById("counterTable").value = countTable;
var range= sel.getRangeAt(0);

myParent=document.getElementById("iframe_editor").contentWindow.document.body;
table=document.createElement("TABLE");

table.id = "tableid"+countTable;

for (i = 1; i <= document.getElementById("numoftr").value; i++)
{
    tr = document.createElement("TR");
    tr.id = table.id+"-"+"trid"+i;

    for (j = 1; j<= document.getElementById("numoftd").value; j++)
    {
        td = document.createElement("TD");
        td.id = tr.id+"-"+"tdid"+j;

        td.addEventListener( 'dblclick', function(){
            loadTableAttribute(td.id);
        },td.id);

        tr.appendChild(td);             
    }
    table.appendChild(tr);
}
table.appendChild(emptyNode);

myParent.appendChild(table);
range.insertNode(table);

LoadTableAttribute

function loadTableAttribute(tdid)
{
    alert(tdid);
}

Possible duplicate of [JavaScript closure inside loops – simple practical example](http://stackoverflow.com/questions/750486/javascript-closure-inside-loops-simple-practical-example) — CBroe, Jan 26 '16 at 18:44
From within the for-loop call an outside function and attach your event there. Not within the for-loop. Second is the last argument of the `attachEventListener` just `true/false` and refers to the bubble phase. Standard is "false". — Daniel, Jan 26 '16 at 18:54

score 0 · Accepted Answer · edited May 23 '17 at 12:15

0

Use var tr = .. and var td = .. and in the listener send this.id to the function: loadTableAttribute(this.id);

EDIT A good post about var usage is this. Always use var in relevant scopes.

edited May 23 '17 at 12:15

Community

1
1

answered Jan 26 '16 at 18:53

guysigner

2,822
1
19
23

thx a lot, i know when i use a variable i have to declare it with "var", but why i don't get an error? thx for your help – Stefan Gum Jan 26 '16 at 19:06
@StefanGum You're welcome. see EDIT, it might help understanding. – guysigner Jan 26 '16 at 19:13

get wrong id after dbliclick - eventlistener

1 Answers1