sharedpreferences getting wrong boolean value

Question

i would like to create a sharedpreferences for boolean value check, but the value always return false. How to return the correct boolean value for sharedpreferences?

Below is my code

  public boolean getBtnState(Context context,String text)//edit to store url here and check the boolean here
{
    SharedPreferences prefs;
    prefs = context.getSharedPreferences(PREFS_NAME, Context.MODE_PRIVATE);

    String favUrl = getPrefsFavUrl(context);

    boolean switchState = false;

    if(favUrl == text) {
        switchState=true;
    }

    return switchState;//always return false here

}

Here is the code to get sharedpreferences value

 @Override
    public Object instantiateItem(final ViewGroup container, final int position) {
        showProgress();
        imageView = (ImageView) findViewById(R.id.btn_favourite);

        Boolean stateBtnNow=sharedPreference.getBtnState(context,mUrl);
         if(stateBtnNow) {
             imageView.setColorFilter(Color.argb(255, 249, 0, 0));//red
         }
        else
         {
             imageView.setColorFilter(Color.argb(255, 192, 192, 192));
         }

score 1 · Accepted Answer · edited May 23 '17 at 12:15

1

You are comparing two String variables with == operator instead use .equals() method.

if(favUrl.equals(text)) {
    switchState=true;
}

it will work.

Refer This Question for == and equals().

edited May 23 '17 at 12:15

Community

1
1

answered Jan 29 '16 at 07:54

ELITE

5,815
3
19
29

score 0 · Answer 2 · edited Jan 30 '16 at 00:14

0

use

if(favUrl.equals(text)){
    switchState = true;
}

instead of

if(favUrl == text) {
    switchState=true;
}

edited Jan 30 '16 at 00:14

David Yee

3,515
25
45

answered Jan 29 '16 at 07:54

Anup Dasari

488
1
4
13

score 0 · Answer 3 · answered Jan 29 '16 at 08:06

You can simplify your code to:

public boolean getBtnState(Context context,String text) { //edit to store url here and check the boolean here
    SharedPreferences prefs = context.getSharedPreferences(PREFS_NAME, Context.MODE_PRIVATE);
    return getPrefsFavUrl(context).equals(text); // fixed and simplified code
}

sharedpreferences getting wrong boolean value

3 Answers3