Same values on each request in Flask

Question

Need to get the same values on each request in my views file. Instead of getting them on every request, I used before_request function and added them to global dict:

options = {}
@app.before_request
def before_request():
    options['ip'] = request.remote_addr
    options['useragent'] = request.user_agent.string

Is it a good solution or not? What can you recommend?

Well I think it's a good way anyway. – Remi Guan Jan 29 '16 at 10:10 — Remi Guan, Jan 29 '16 at 10:10

score 1 · Answer 1 · answered Jan 29 '16 at 10:20

1

No, this is a very bad idea. Although the request is a thread-local, so you can access it everywhere, your options dict is not; it is not threadsafe, and will therefore be shared across all requests.

answered Jan 29 '16 at 10:20

Daniel Roseman

588,541
66
880
895

This dict contains config to interop with APIs with GET/POST requests and it is already shared across all requests. What about this particular case? – asyndrige Jan 29 '16 at 10:37
You're adding request-specific data to it now, though. That is not safe. – Daniel Roseman Jan 29 '16 at 10:43

score 1 · Accepted Answer · answered Jan 29 '16 at 13:12

1

The correct answer to this is to use Flask's g object. You can read about this here: http://flask.pocoo.org/docs/0.10/api/#flask.g

answered Jan 29 '16 at 13:12

Ryan O'Donnell

617
6
14

Same values on each request in Flask

2 Answers2