Getting an error while creating factory object

Question

I have a module and controller which are created like :

var API_ENGINE_URL = 'localhost/angular/';
var mainApp = angular.module('mainApp', ['ngRoute', 'ngResource']);


mainApp.controller('productController', ['$scope', 'ProductFactory', 'ProductListFactory','$routeParams', function ($scope, ProductFactory,routeParams, ProductListFactory) {
    var productList = new ProductListFactory();// THROWS ERROR HERE
    var promise = productList.$get({id: $routeParams.category_id}).$promise;
    promise.then(function (productList) {
        $scope.productList = productList;
    });
}]);

and the Model is created like this, files are properly loaded

 mainApp.factory('ProductListFactory', ['$resource',function ($resource) {
    return $resource(API_ENGINE_URL + 'category/:id/items', {}, {
        get: {method: 'GET', params: {category_id: '@category_id', id: '@id'},isArray:true,url:API_ENGINE_URL+'product?store_id=:storeId'},
        save: {method: 'GET', isArray: true}

    });
}]);

I am getting an error in the controller like below. what could be the error. Stuck for a long time

Could this be what you're looking for ? http://stackoverflow.com/questions/20800909/angularjs-return-new-factory-instance — Martijn Welker, Jan 29 '16 at 12:55

score 1 · Answer 1 · answered Jan 29 '16 at 12:56

In a factory function, the return value is what's cached and injected by Angular. There is no need to instantiate it yourself.

Try this:

mainApp.controller('productController', ['$scope', 'ProductFactory', 'ProductListFactory','$routeParams', function ($scope, ProductFactory,routeParams, ProductListFactory) {
    var promise = ProductListFactory.$get({id: $routeParams.category_id}).$promise;
    promise.then(function (productList) {
        $scope.productList = productList;
    });
}]);

@Aman @pixelbits . there are 3 problems . 1. usage of `new` 2. Ordering 3. using `.$get` instead of `get` . Thanks a lot both of you! — notnotundefined, Jan 29 '16 at 13:05

score 1 · Answer 2 · answered Jan 29 '16 at 13:00

1

Problem is in ordering should be :

['$scope', 'ProductFactory', 'ProductListFactory','$routeParams', function ($scope, ProductFactory,ProductListFactory,$routeParams)

answered Jan 29 '16 at 13:00

Aman Gupta

3,627
4
40
64

Getting an error while creating factory object

2 Answers2