SwipeRefreshLayout loader not going up when pull down android

Question

I have used SwipeRefreshLayout with recyclerview, Its working fine in all android version but in Kitkat when i pull down then SwipeRefreshLayout loader not going up and also doesn't refresh recyclerview data but working in lollipop

I am using 'com.android.support:support-v4:22.2.1'

Edit 1

SwipeRefreshLayout swipe_refresh;
swipe_refresh = (SwipeRefreshLayout)rootView.findViewById(R.id.swipe_refresh);

swipe_refresh.post(new Runnable() {
            @Override
            public void run() {
                swipe_refresh.setRefreshing(true);
            }
        });


swipe_refresh.setOnRefreshListener(new SwipeRefreshLayout.OnRefreshListener() {
            @Override
            public void onRefresh() {
                // Loading more data..
                .....
                ....
                getData();

            }
        });

swipe_refresh.setColorSchemeResources(android.R.color.holo_blue_bright,
                android.R.color.holo_green_light,
                android.R.color.holo_orange_light,
                android.R.color.holo_red_light);

public void getData(){
    // Load data from web service...
    ...
    ...
    ...


    // After loading
    swipe_refresh.setRefreshing(false);

    // Set data to adapter
}

Layout Code

<?xml version="1.0" encoding="utf-8"?>
<android.support.v4.widget.SwipeRefreshLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:id="@+id/swipe_refresh"
    android:orientation="vertical"
    android:layout_width="match_parent"
    android:layout_height="match_parent">

    <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:orientation="vertical" android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:gravity="center"
    android:background="@color/grey_100">

     <LinearLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:orientation="vertical">

            <android.support.v7.widget.RecyclerView
                android:id="@+id/gv_feeds"
                android:layout_width="match_parent"
                android:layout_height="0dp"
                android:layout_weight="9"
                android:scrollbars="vertical"/>

            <ProgressBar
            android:id="@+id/prog_load_more"
            android:layout_width="40dp"
            android:layout_height="40dp"
            android:layout_gravity="center_horizontal"
            android:visibility="gone"/>

            </LinearLayout>

        </FrameLayout>

</android.support.v4.widget.SwipeRefreshLayout>

Do you call swipeRefreshLayout.setRefreshing(false); when loading data is finished? — David Rauca, Jan 30 '16 at 11:33
Yes, i am.. when i pull down again to refresh then it stuck on screen, i can pull it up by dragging... — Faisal Tai, Jan 30 '16 at 11:49
The code seems to be ok. Do you call setRefreshing(false) even if the request fails? — David Rauca, Jan 30 '16 at 12:09
On version "com.android.support:support-v4:23.1.1", the problem still exists. — Ugurcan Yildirim, Feb 01 '16 at 14:23
@FaisalTai i don't think so; put some log on your code and check if *setRefreshing(false)* is called correctly (for example, put it on a method which take a boolean as parameter and log when the method is called). BTW, why you launch/use **swipe_refresh.post(...)** and when it's launched? Sincerely, i will put *swipe_refresh.setRefreshing(true);* on **onRefresh()** directly, without a *Runnable*. — JJ86, Feb 05 '16 at 10:01

score 2 · Answer 1 · answered Feb 05 '16 at 20:31

I have had the same issue before. It seems to happen when you don't have your RecyclerView as a direct child of your SwipeRefreshLayout.

We fixed this issue by using a custom SwipeRefreshLayout like this one:

public class FixedSwipeRefreshLayout extends SwipeRefreshLayout {

    private RecyclerView recyclerView;

    public FixedSwipeRefreshLayout(Context context, AttributeSet attrs) {
        super(context, attrs);
    }

    public FixedSwipeRefreshLayout(Context context) {
        super(context);
    }

    public void setRecyclerView(RecyclerView recyclerView) {
        this.recyclerView = recyclerView;
    }

    @Override
    public boolean canChildScrollUp() {
        if (recyclerView!=null) {
            return recyclerView.canScrollVertically(-1);
        }

        return false;
    }

}

Then, instead of using android.support.v4.widget.SwipeRefreshLayout use your own 'com.example.app.FixedSwipeRefreshLayout' like this:

<?xml version="1.0" encoding="utf-8"?>
<com.example.app.FixedSwipeRefreshLayout
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:id="@+id/swipe_refresh"
    android:orientation="vertical"
    android:layout_width="match_parent"
    android:layout_height="match_parent">
...
</com.example.app.FixedSwipeRefreshLayout>

And finally, when you get a handle of your SwipeRefreshLayout, use your custom one and set your RecyclerView:

FixedSwipeRefreshLayout swipe_refresh;
swipe_refresh = (FixedSwipeRefreshLayout) rootView.findViewById(R.id.swipe_refresh);
RecyclerView mRecyclerView = (RecyclerView) rootView.findViewById(R.id.gv_feeds);
swipe_refresh.setRecyclerView(mRecyclerView);

Hope this helps.

score 1 · Answer 2 · answered Feb 08 '16 at 07:03

As per swipeRefreshDocumentation SwipeRefreshLayout does not play well with layout that are not scrollable if added inside it : you have 2 solution for this:

1)change your layout to make swipeRefreshLayout to have direct child as recyclerView .

something like this:

<?xml version="1.0" encoding="utf-8"?>

    <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
        android:orientation="vertical" android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:gravity="center"
        android:id="@+id/ll_HeaderProgress"
        android:background="@color/white_color_30">

        <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:orientation="vertical">
            <android.support.v4.widget.SwipeRefreshLayout
                xmlns:android="http://schemas.android.com/apk/res/android"
                android:id="@+id/swipe_refresh"
                android:orientation="vertical"
                android:layout_width="match_parent"
                android:layout_height="0dp"
                android:layout_weight="9"
               >
            <android.support.v7.widget.RecyclerView
                android:id="@+id/recyclerview_buzz"
                android:layout_width="match_parent"
                android:layout_height="match_parent"
                android:scrollbars="vertical"/>
</android.support.v4.widget.SwipeRefreshLayout>
            <ProgressBar
                android:id="@+id/ll_footerProgress"
                android:layout_width="40dp"
                android:layout_height="40dp"
                android:layout_gravity="center_horizontal"
                android:visibility="gone"/>
        </LinearLayout>
    </FrameLayout>

2)Extend SwipeRefreshLayout with listener to be able to add various conditions from the classes that display this layout.

Something like the following: RefreshSwipeRefreshLayout.java

public class RefreshSwipeRefreshLayout extends SwipeRefreshLayout {   
  private OnChildScrollUpListener mScrollListenerNeeded;

  public interface OnChildScrollUpListener {
    boolean canChildScrollUp();
  }

  public RefreshSwipeRefreshLayout(Context context) {
    super(context);   
  }
  public RefreshSwipeRefreshLayout(Context context, AttributeSet attrs) {
    super(context, attrs);   
  }

 /**
  * Listener that controls if scrolling up is allowed to child views or not
  */
  public void setOnChildScrollUpListener(OnChildScrollUpListener listener) {
    mScrollListenerNeeded = listener;   
  }

  @Override
  public boolean canChildScrollUp() {
    if (mScrollListenerNeeded == null) {
      Log.e(GeneralSwipeRefreshLayout.class.getSimpleName(), "listener is not defined!");
    }
    return mScrollListenerNeeded != null && mScrollListenerNeeded.canChildScrollUp();
  }
}

and Then do this in class that displays SwipeRefreshLayout containing recyclerView layout, you can do something like this:

mSwipeLayout.setOnChildScrollUpListener(new OnChildScrollUpListener() {
  @Override
  public boolean canChildScrollUp() {
    return   ((LinearLayoutManager)mRecyclerView.getLayoutManager()).findFirstVisibleItemPosition().getFirstVisiblePosition() > 0 || 
           mRecyclerView.getChildAt(0) == null || 
           mRecyclerView.getChildAt(0).getTop() < 0;
  }

});

Also dont forget to change it in xml

score 0 · Answer 3 · answered Feb 05 '16 at 19:14

You try this way

   listView.setOnScrollListener(new OnScrollListener() {

    @Override
    public void onScrollStateChanged(AbsListView view, int scrollState) {
    }

    @Override
    public void onScroll(AbsListView view, int firstVisibleItem,
            int visibleItemCount, int totalItemCount) {
        boolean enable = false;
        if(listView != null && listView.getChildCount() > 0){
            // check if the first item of the list is visible
            boolean firstItemVisible = listView.getFirstVisiblePosition() == 0;
            // check if the top of the first item is visible
            boolean topOfFirstItemVisible = listView.getChildAt(0).getTop() == 0;
            // enabling or disabling the refresh layout
            enable = firstItemVisible && topOfFirstItemVisible;
        }
        swipeRefreshLayout.setEnabled(enable);
    }});

score 0 · Answer 4 · answered Aug 26 '17 at 07:52

I might be late to answer this but I've had the same issue, all I did is to add:

swipe_refresh.setOnRefreshListener(new SwipeRefreshLayout.OnRefreshListener() {
    @Override
    public void onRefresh() {
        // Loading more data..
        .....
        ....
        getData();

        //make sure to set it to false as this will be set it to true when onRefresh is triggered
        swipe_refresh.setRefreshing(false);
    }
});

SwipeRefreshLayout loader not going up when pull down android

4 Answers4

Linked