2

The objective is to add a maintenance batch on the same url of the administration of an Azure MVC site. The url should be something like:

https://admin.mysite.com/Batch?pass=HKE671

I decided to override OnActionExecuting and to capture the information I need in the url to trigger the maintenance method. I am not familiar with MVC projects, and this may not sound very conventional... 

  protected override void OnActionExecuting(ActionExecutingContext filterContext)
  {
      EmailUtility.SendSupportEmail("DEBUG - On result executing", ""); //I receive this email
      int y = 14;
      if (Request.Url.Query.Length > y)
      {
          string url = Request.Url.Query.Remove(0, y); // I remove ?ReturnUrl=%2f
          if (url.StartsWith("Batch"))
          {
              mySite.Admin.Web.Controllers.TenantController controller = new mySite.Admin.Web.Controllers.TenantController();
              EmailUtility.SendSupportEmail("DEBUG - starts maintenance", ""); // I don't receive this one
              controller.maintenance(HttpUtility.ParseQueryString(url).Get("pass"));
          };
      }
      base.OnActionExecuting(filterContext);
  }

This code works as well as I need on local, the maintenance method is called and does the job. But when deployed on Azure, this modification throws a 404 error. Interestingly, I send two debug emails : I don’t receive the second one "DEBUG - starts maintenance", therefore my 404 error comes from the instantiation of a controller in OnActionExecuting.

First, I would like to understand why is the behavior different between my development machine and Azure?

Then, how can I make it work? Thanks,

EDITED on Jan 4:
I made a little progress, but this issue is still unsolved.
- About the difference between my dev machine and Azure: there are a few redirections on this site: https, 404 and non-existent domain. I assumed it was due to a 404 error. Encapsulating the code with a try/catch didn't sent me any error, so I am guessing that I can suppress the 404 from the hypothesis.
- I tried the code above on OnAuthorization without having more success.
- I noticed that the first email DEBUG - On result executing is in fact sent at the first test only. It is not sent the second time I run my test. This doesn't make any sense to me, because the session should be checked every time.

Conclusion for today: it seems to be more a routing/redirection problem.

Manor
  • 61
  • 8

2 Answers2

0

Why don't you do:

      protected override void OnActionExecuting(ActionExecutingContext filterContext)
      {    
         try {
            //your code here
         } catch (Exception ex){
            EmailUtility.SendSupportEmail("Execution failed: " + ex.Message , "");
         }
      }

If your code is throwing an exception, this should give you a better understanding on why it is failing.

But more important, a more robust way of checking for the correct URL would be:

if (filterContext.HttpContext.Request.Url.AbsolutePath.EndsWith("Batch")){
}

As far as i can tell your string variable "url" will not ever start with "Batch", because Request.Url.Query only conains the part after the "?" thus making your check always return false. Why this IS working on localhost is hard to tell, but in my opinion it shouldn't.

Actually, to work in all cases your check should be:

if (filterContext.HttpContext.Request.Url.AbsolutePath.ToLower().EndsWith("batch") || filterContext.HttpContext.Request.Url.AbsolutePath.ToLower().EndsWith("batch/")){
}

After your edit: Ok, so what's happening is that you're requesting the action "Batch" in Home Controller, but because you're not authenticated you are redirected to LogOn in Account Controller. You should be seeing a login page, unless there's no associated LogOn view in your Views folder, or no AccountController at all, in both cases an exception is thrown.

Is the Batch method supposed to check for authentication? If not, remove the [Authorize] annotation from this method in HomeController and you should be fine.

You still have to adjust the if-check though, because it actually only evaluates to true on the LogOn page, and false if you actually get to the Batch page.

enter.net
  • 1
  • 1
  • I dont think that answers the question in any way – mikus Feb 01 '16 at 16:32
  • Added a second, more important, suggestion – enter.net Feb 01 '16 at 16:36
  • Actually my check works, because I suppress the 14 first characters of my query (?ReturnUrl=%2f) and then test if "Batch" exists in the beginning of the remaining string. It works fine on my development computer. – Manor Feb 01 '16 at 18:09
  • On your dev computer set a breakpoint on the line with the if statement and then add two watches in the debugger: one on "url" and another on "filterContext.HttpContext.Request.Url" I'm curious about these two values – enter.net Feb 02 '16 at 08:23
  • `filterContext.HttpContext.Request.Url` is `http://localhost:6146/Account/LogOn?ReturnUrl=%2fBatch%3fpass%3dHKE671&pass=HKE671` and `url` is `Batch%3fpass%3dHKE671&pass=HKE671` – Manor Feb 04 '16 at 03:41
  • Hi enter.net, I tried catching an exception as you suggested, and I didn't received anything. This made me realize that my problem may not be where I think it is... I will update my question accordingly. – Manor Feb 04 '16 at 19:33
0

Shame on me, the problem was somewhere else!... The code above works well, but the routing of this site rejected an incomplete url. In this case, it had to contain the project name: https://admin.mysite.com/Admin/Batch?pass=HKE671 Then all is back to normal!

So the answer is: the behavior is different on my local computer because the local host of my development machine doesn't route projects of the solution the same way Azure does.

Many thanks for your help!

Manor
  • 61
  • 8