Why isn't this code working ? (Python)

Question

So I'm making a code that accepts a number with only 8 or 7 digits and then if the user enters an 8 digit number then it should add all 8 digits together then divide by 10 and print out the answer. I have been trying to change the user's input into a list but it hasn't been working out.
My current code (not working):

NumGiven=''
while not NumGiven.isnumeric():
    NumGiven=(input('Please enter a 7 or 8 digit number:'))
while len(NumGiven)<7 or len(NumGiven)>8:
    NumGiven=(input('Please enter a 7 or 8 digit number:'))
if len(NumGiven)==8:
    list=[int(i) for i in NumGiven.split()]

I think there is something wrong with the last line, I looked at many other topics but they never seemed to work. Can some one help me tweak this code.

Voting to reopen. The supposed duplicate question is about reading integers, but this one is about string splitting. — recursive, Feb 01 '16 at 17:05
What is the behavior you observe that leads you to believe that it is not working? — pat, Feb 01 '16 at 17:06
your last line should be something like `print(sum([int(i) for i in NumGiven]))` — domoarigato, Feb 01 '16 at 17:07

score 2 · Answer 1 · answered Feb 01 '16 at 17:04

2

NumGiven.split() splits on whitespace, but there probably isn't any. Since you want to iterate over characters, you can just eliminate the .split().

list=[int(i) for i in NumGiven]

answered Feb 01 '16 at 17:04

recursive

83,943
34
151
241

1

Also, it's usually a good idea to avoid using identifiers such as `list`, since that is a python builtin. Use `the_list` or `_list` or `digits`. – Håken Lid Feb 01 '16 at 17:08
thanks for your answer,so if I use the line you have given me , will it turn my string to a list meaning I can add the 8 digits together ? – wdwdwdw Feb 01 '16 at 17:09
@HåkenLid thanks for the suggestion – wdwdwdw Feb 01 '16 at 17:09
@wdwdwdw: Yes, it will give you a list. – recursive Feb 01 '16 at 17:11
EDIT: thanks it all works now , I appreciate your help. – wdwdwdw Feb 01 '16 at 17:13
You could show your appreciation by selecting recursive's answer as the correct one! – pat Feb 02 '16 at 16:39

domoarigato · Answer 2 · 2016-02-01T17:10:37.613

0

OP asked for the sum - it should be:

 print(sum([int(i) for i in NumGiven])/10.0)

edited Feb 01 '16 at 17:10

answered Feb 01 '16 at 17:09

domoarigato

2,802
4
24
41

you forgot to divide by 10. – Håken Lid Feb 01 '16 at 17:09
@domo Thanks , I know how to do it , it was just turning the string into a list , but thanks. – wdwdwdw Feb 01 '16 at 17:11
Thanks you very much guys xD – wdwdwdw Feb 01 '16 at 17:13

Why isn't this code working ? (Python)

2 Answers2