Email validation doesnt work properly

Question

I have this code:

$checkDB = "SELECT email FROM users WHERE email='$email'";
$result = mysqli_query($conn, $checkDB);
$row = mysqli_fetch_array($result, MYSQLI_ASSOC);

if (mysqli_num_rows($result) == 1) {
    $errorEmail = 'This email is registered m8';
    $mainError = true;
}

So the problem is that it always says that the email is registered even if it is not for the email check (email check is after name check). I tried changing variable names but it doesnt work.

$checkDB = "SELECT user_name FROM users WHERE user_name='$name'";
    $result = mysqli_query($conn, $checkDB);
    $row = mysqli_fetch_array($result, MYSQLI_ASSOC);

    if (mysqli_num_rows($result) == 1) {
        $errorName = 'Name registered';
        $mainError = true;
    }

Not cleared u want to print name error first than email error — devpro, Feb 02 '16 at 20:21
Are you wiping your database between tests? Or using new data every time? — Stewart Smith, Feb 02 '16 at 20:34

score 0 · Answer 1 · edited Feb 02 '16 at 20:46

0

mysqli_num_rows($result); checks the numbers of rows of found email. And don't put mysqli_fetch_array($result, MYSQLI_ASSOC);. I don't know why but its work for me.

Use this code

$checkDB = "SELECT email FROM users WHERE email='$email'";
$result = mysqli_query($conn, $checkDB);
$check = mysqli_num_rows($result);

if ( $check == 1) {
    $errorEmail = 'This email is registered m8';
    $mainError = true;
}

edited Feb 02 '16 at 20:46

Martin

22,212
11
70
132

answered Feb 02 '16 at 20:26

saqib kifayat

136
2
14

what does this rearrangement of current code achieve? – Martin Feb 02 '16 at 20:27
mysqli_num_rows($result); check the numbers of email. and don't put mysqli_fetch_array($result, MYSQLI_ASSOC); i don't know why but its work for me – saqib kifayat Feb 02 '16 at 20:32

score 0 · Answer 2 · answered Feb 02 '16 at 20:35

You should check if it is greater to zero
Fetching is not necessary
Also in your stituation you should be preparing your statment.

$checkDB = "SELECT email FROM users WHERE email= ?";
if ($result = mysqli_prepare($conn, $checkDB)) {
    mysqli_stmt_bind_param($result, "s", $email);
    mysqli_stmt_execute($result );
    if(mysqli_num_rows($result) > 0){
        $errorName = 'Name registered';
        $mainError = true;
    }
}
mysqli_close($conn);

Email validation doesnt work properly

2 Answers2