How can I send an Ajax Request on button click from a form with 2 buttons?

Question

I want to send a request from one page to another from a form which has 2 buttons:

<form method="post">
    <button id="button_1" value="val_1" name="but1">button 1</button>
    <button id="button_2" value="val_2" name="but2">button 2</button>
    <input id="access_token" type="hidden" name="access_token" value="<?php echo $_SESSION['access_token']; ?>" />
</form>

$(document).ready(function() {
  $("#button_1").click(function(e) {
    e.preventDefault();
    $.ajax({
      type: "POST",
      url: "/pages/test/",
      data: {
        id: $("#button_1").val(),
        access_token: $("#access_token").val()
      },
      success: function(result) {
        alert('ok');
      },
      error: function(result) {
        alert('error');
      }
    });
  });

  $("#button_2").click(function(e) {
    e.preventDefault();
    $.ajax({
      type: "POST",
      url: "/pages/test/",
      data: {
        id: $("#button_2").val(),
        access_token: $("#access_token").val()
      },
      success: function(result) {
        alert('ok');
      },
      error: function(result) {
        alert('error');
      }
    });
  });
});

How can I improve this code and maybe merge it into one function?

score 61 · Accepted Answer · answered Feb 04 '16 at 14:07

61

Given that the only logical difference between the handlers is the value of the button clicked, you can use the this keyword to refer to the element which raised the event and get the val() from that. Try this:

$("button").click(function(e) {
    e.preventDefault();
    $.ajax({
        type: "POST",
        url: "/pages/test/",
        data: { 
            id: $(this).val(), // < note use of 'this' here
            access_token: $("#access_token").val() 
        },
        success: function(result) {
            alert('ok');
        },
        error: function(result) {
            alert('error');
        }
    });
});

answered Feb 04 '16 at 14:07

Rory McCrossan

331,213
40
305
339

1

Yeah, thanks I'm new to Stackoverflow - currently trying to figure out things! :) – Max Maxymenko Feb 04 '16 at 14:22
This worked. but i am trying to get pick out the `name` from my json data returned and i get undefined. i map it this way `alert(result.name)` – Oct 26 '17 at 14:38
The answer to that depends entirely on how your JSON is structured. I'd suggest starting a new question for it – Rory McCrossan Oct 26 '17 at 14:39

score 13 · Answer 2 · answered Feb 04 '16 at 14:32

Use jQuery multiple-selector if the only difference between the two functions is the value of the button being triggered.

$("#button_1, #button_2").on("click", function(e) {
    e.preventDefault();
    $.ajax({type: "POST",
        url: "/pages/test/",
        data: { id: $(this).val(), access_token: $("#access_token").val() },
        success:function(result) {
          alert('ok');
        },
        error:function(result) {
          alert('error');
        }
    });
});

Thanks, will give this a shot! :) – Max Maxymenko Feb 04 '16 at 14:40 — Max Maxymenko, Feb 04 '16 at 14:40

score 6 · Answer 3 · answered Feb 04 '16 at 14:15

function sendAjaxRequest(element,urlToSend) {
             var clickedButton = element;
              $.ajax({type: "POST",
                  url: urlToSend,
                  data: { id: clickedButton.val(), access_token: $("#access_token").val() },
                  success:function(result){
                    alert('ok');
                  },
                 error:function(result)
                  {
                  alert('error');
                 }
             });
     }

       $(document).ready(function(){
          $("#button_1").click(function(e){
              e.preventDefault();
              sendAjaxRequest($(this),'/pages/test/');
          });

          $("#button_2").click(function(e){
              e.preventDefault();
              sendAjaxRequest($(this),'/pages/test/');
          });
        });

created as separate function for sending the ajax request.
Kept second parameter as URL because in future you want to send data to different URL

How can I send an Ajax Request on button click from a form with 2 buttons?

3 Answers3

Linked