Why cant multiple users access my website?

Question

I'm trying to build a website using C# MVC nHibernate. All works well, but when i navigate my website in multiple browsers i get the error:

There is already an open DataReader associated with this Connection which must be closed first.

I have binded many of my services to one session (ISession).

        //ContentService Bingings
        Bind<IContentService>().To<ContentService>().InRequestScope();
        Bind<ISession>()
            .ToMethod(
                context =>
                    context.Kernel.Get<IMasterSessionSource>()
                        .ExposeConfiguration()
                        .BuildSessionFactory()
                        .OpenSession()
            )
            .WhenInjectedInto<IContentService>()
            .InSingletonScope();

        //GeneralService Bindings
        Bind<ISession>()
            .ToMethod(
                context =>
                    context.Kernel.Get<IMasterSessionSource>()
                        .ExposeConfiguration()
                        .BuildSessionFactory()
                        .OpenSession())
            .WhenInjectedInto<IGeneralService>()
            .InSingletonScope();

        Bind<IGeneralService>()
            .To<GeneralService>()
            .InSingletonScope();

        //CrossSellService Bindings
        Bind<ISession>()
            .ToMethod(
                context =>
                    context.Kernel.Get<IMasterSessionSource>()
                        .ExposeConfiguration()
                        .BuildSessionFactory()
                        .OpenSession())
            .WhenInjectedInto<ICrossSellService>()
            .InSingletonScope();

        Bind<ICrossSellService>()
            .To<CrossSellService>()
            .InSingletonScope();


        //Details Bindings
        Bind<ISession>()
                       .ToMethod(
                           context =>
                               context.Kernel.Get<IMasterSessionSource>()
                                   .ExposeConfiguration()
                                   .BuildSessionFactory()
                                   .OpenSession())
                       .WhenInjectedInto<IDetailsService>()
                       .InRequestScope();

        Bind<IDetailsService>()
            .To<DetailsService>()
            .InRequestScope();

and they get called for other uses. for example my DetailsService:

public interface IDetailsService { //OVERRIDES HERE;
}

public class DetailsService : IDetailsService
{
    private static IContentService Context { get; set; }

    public DetailsService(IContentService context)
    {
        Context = context;
    }
 ...

where IContentService is my main Query class:

 public interface IContentService
 {

    IQueryable<Source> Sources { get; }
  }

public class ContentService : IContentService
{
    private readonly ISession _session;
    public ContentService(ISession session)
    {
        _session = session;
    }

   public IQueryable<Source> Sources
    {
        get { return _session.Query<Source>(); }
    }

not sure why its not accessing multiple queries

score 2 · Answer 1 · answered Feb 04 '16 at 16:39

2

This is going to sound very random, but a colleague of mine had a similar issue in the application we support. He said the issue was related to using a Singleton. It was fixed by changing to transient.

answered Feb 04 '16 at 16:39

Baaleos

1,703
12
22

score 2 · Accepted Answer · edited May 23 '17 at 11:45

2

The reason it looks like this is happening is because you are trying to use the same ISession across different threads. The reason it's doing this is because of this:

Bind<ISession>()
        ...
        .InSingletonScope();

Your session should not be a singleton in a web environment. I would recommend using nhibernate contextual sessions.

Why does Nhibernate share the session across multiple requests in my MVC application?

edited May 23 '17 at 11:45

Community

1
1

answered Feb 05 '16 at 13:44

Cole W

15,123
6
51
85

i changed my service to InSingtonScope() but its still giving me the error – NeoSketo Feb 05 '16 at 16:10
Apparently i was reading that it has something to do with muti-threading ISession. – NeoSketo Feb 08 '16 at 13:09

Why cant multiple users access my website?

2 Answers2