Reveres the string doesn't work in C

Asked Feb 10 '16 at 01:25

Active Feb 10 '16 at 01:25

Viewed 23 times

I have a reversing-a-string program below which didn't work. A line "str[start] = str[end];" in the while loop caused it to end prematurely (it's marked down below).

Any pointers appreciated.

#include <iostream>
using namespace std;

int main() {
    int end, start;
    char temp;
    char* str = "hello";
    start = 0;
    end = strlen(str) - 1;

    while(end > start)
    {
        temp = str[start];
        str[start] = str[end];   // <------------- This line caused issue
        str[end] = temp;
        start++; end--;
    }

    // print out string
    int i = 0;
    while (str[i])
        printf("%c\n", str[i++]);
}

asked Feb 10 '16 at 01:25

user1972031

2

Change `char* str = "hello";` to `char str[] = "hello";`. – r3mainer Feb 10 '16 at 01:29
2

I think you mean `#include `! This is what you need http://stackoverflow.com/questions/784417/reversing-a-string-in-c – David Corbin Feb 10 '16 at 01:31
Thanks much, the answers helped me answer my question. (char* is immutable; whereas char [] is mutable.) – user1972031 Feb 10 '16 at 01:38
Does this actually compile for you? What compiler are you using? And are you sure you're writing C? – shoover Feb 10 '16 at 01:47

Reveres the string doesn't work in C

Any pointers appreciated.

0 Answers0