Using a variable within a header("location: ")

Question

I have produced a variable up the page and then want to output it for the end of the location redirect, I have checked the sendlink by echoing it and putting it into the browser and all seems to be right, not sure why this isn't working

$sendlink = "landing.php?destination1=" . $destination1 . "&destination2=" . $destination2 . "";

if($destination1 & $destination2 != ""){
    header( "Location: /" . $sendlink );
}

Enable error-reporting [`error_reporting(E_ALL);`](http://php.net/manual/en/function.error-reporting.php) [`ini_set('display_errors', 1);`](http://php.net/manual/en/function.ini-set.php) - you probably get a "*Header already sent..*" warning (or another type of error, you should check for it). — Qirel, Feb 11 '16 at 15:57
`if($destination1 &` < missing one of those. and you need to use a different logic. — Funk Forty Niner, Feb 11 '16 at 15:58
`if($destination1 != "" && $destination2 != "")` or use `empty()`. — Funk Forty Niner, Feb 11 '16 at 15:59

Panda · Answer 1 · 2016-02-11T16:20:47.577

2

To achieve this, there are quite a few methods.

Method 1 !empty():

if((!empty($destination1)) && (!empty($destination2))) {
    header( "Location: /" . $sendlink );
}

Method 2 isset() (Not Set):

if((isset($destination1)) && (isset($destination2))) {
    header( "Location: /" . $sendlink );
}

Method 3 !=='':

if(($destination1 !== '') && ($destination2 !== '')) {
    header( "Location: /" . $sendlink );
}

edited Feb 11 '16 at 16:20

answered Feb 11 '16 at 16:00

Panda

6,955
6
40
55

I think OP wants the opposite of each of the first two (`!empty()` and `!isset()`). Also, there's no need for the parentheses around those expressions. – elixenide Feb 11 '16 at 16:11

score 2 · Accepted Answer · edited May 23 '17 at 11:59

Seeing all those other answers popping up....

First, you're missing an ampersand in your conditional statement.

if($destination1 & $destination2 != "")
                  ^ missing an ampersand here

There should be two of those and you also need to use the same logic for both variables.

if($destination1 != "" && $destination2 != "") or use a conditional empty() on both also.

I.e.: !empty(). The ! operator stands for "not" empty.

References:

Another thing; it's best to add an exit; after header, should you have more code below that. Otherwise, it may want to continue executing the rest of the script.

Reference:

http://php.net/manual/en/function.header.php

While making sure you're not outputting before header.

Consult the following if you get a headers sent notice:

How to fix "Headers already sent" error in PHP

score 0 · Answer 3 · edited May 23 '17 at 11:50

0

Provided by: Fred -ii-

if($destination1 != "" && $destination2 != "") or use empty()

edited May 23 '17 at 11:50

Community

1
1

answered Feb 11 '16 at 16:00

Lewis Smith

1,271
1
14
39

Using a variable within a header("location: ")

3 Answers3