Getting value of UmbracoContext.Current as null

Question

I am having the following code on my Home Controller / Viewmodel class

public class HomeController : SurfaceController {
      ....


  [AllowAnonymous]   
public ActionResult LoginIn()  
 {
    var user = new UserDetail() { FirstName = "FirstName", LastName = "LastName" };
    UserDetailViewModel model = new UserDetailViewModel() { User = user };
    return PartialView("~/Views/Partials/__LoginPartial.cshtml", model);

  }
     ........ 
}

public class UserDetailViewModel : RenderModel
 {    
        public UserDetailViewModel() : this(new UmbracoHelper(UmbracoContext.Current).TypedContent(UmbracoContext.Current.PageId)) { }
        public UserDetailViewModel(IPublishedContent content, CultureInfo culture) : base(content, culture) { }
        public UserDetailViewModel(IPublishedContent content) : base(content) { }
        public UserDetail User { get; set; } 
    }

And following is the ActionExcuteFilter

[AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, AllowMultiple = false, Inherited = true)] public sealed class ActionExcuteFilter : ActionFilterAttribute {
    public override void OnActionExecuting(ActionExecutingContext filterContext)
    {
        if (HttpContext.Current.Session == null || Convert.ToInt32(HttpContext.Current.Session["UserId"]) ==0)
        {
            var myAccountPage = uQuery.GetNodesByType("Login").FirstOrDefault();

            filterContext.Result = new RedirectToRouteResult(
                new RouteValueDictionary {
                { "action", "LoginIn" },
                { "controller", "Home" }});

        }
        base.OnActionExecuting(filterContext);
    } }

And on Home page have the following link

http://localhost/Products?categoryId=1 Which refer to action of product controller.

So if user get login, and click on link everything works fine. (Means to say getting the value from UmbracoContext and respective pages get rendered )

But when user Click on the link without login trouble starts (get error while fetching the values from UmbracoContext )

So the Execution is:

Product controller is call > ActionExcuteFilter > RedirectToRouteResult > Home Controller >LoginIn Action > UserDetailViewModel > Gives error (getting UmbracoContext.Current as null)

So what I am trying to do is that, when user try to access page ..Product?categoryId=1 without login he should be redirect to login page.

Thanks in advance :)

Convert.ToInt32(HttpContext.Current.Session["UserId"]) can throw an exception as UserId could be null — Laurent Lequenne, Mar 05 '19 at 14:34

score 0 · Answer 1 · answered Mar 05 '19 at 14:45

You can try this if your UmbracoContext.Current is null, even it this situtation seems weird. Probably SurfaceController does not need a non null UmbracoContext. Maybe you should redirect to a RenderMvcController

 UmbracoContext.EnsureContext(new HttpContextWrapper(HttpContext.Current), 
                              ApplicationContext.Current,  true);

Getting value of UmbracoContext.Current as null

1 Answers1