"Error: Redefinition of Class" - But No Redeclaration

Question

So I have this header file:

#include <iostream>
#include <string>

class Furniture
{
    float width, height, depth;
    std::string name;

public:
    // Constructor
    Furniture(std::string name);
    void ReadDimensions();
    virtual void Print();
};

And this .cc file to define the functions declared above:

#include "Furniture.h"

Furniture::Furniture(std::string name)
{
    this->name = name;
}

void Furniture::ReadDimensions()
{
    // Read width
    std::cout << "Enter width: ";
    std::cin >> width;
    // Read height
    std::cout << "Enter height: ";
    std::cin >> height;
    // Read depth
    std::cout << "Enter depth: ";
    std::cin >> depth;

    if (width <= 0 || height <= 0 || depth <=0)
            std::cout << "You entered invalidd values\n";
}

And when I try to compile my main file which includes two child classes written in their own files, it gives me an error which reads

"Furniture.h:4: error: redefinition of ‘class Furniture’

Furniture.h:5: error: previous definition of ‘class Furniture’"

But as far as I know I declared the class correctly and didn't redeclare it in the definition. Why is it giving me this error and what can I do to fix it?

Do you also have `#include "Furniture.h"` in the cc file main is in? Are you including the furniture cc file anywhere? — NathanOliver, Feb 17 '16 at 18:16

score 7 · Accepted Answer · answered Feb 17 '16 at 18:25

7

Try adding following code in your .h file. This will prevent redefinition.

#ifndef __FURNITURE_H__
#define __FURNITURE_H__

#include <iostream>
#include <string>

class Furniture
{
    float width, height, depth;
    std::string name;

public:
    // Constructor
    Furniture(std::string name);
    void ReadDimensions();
    virtual void Print();
};

#endif

answered Feb 17 '16 at 18:25

Sudipta Kumar Sahoo

1,049
8
16

2

I would skip the double underscores, as such [names are reserved](http://stackoverflow.com/questions/9668947/reserved-names-in-the-global-namespace) for the implementation. – Bo Persson Feb 17 '16 at 18:28
BTW, the subject of your answer is called *include guards*. – Thomas Matthews Feb 17 '16 at 19:53
Thank you so much I'll make sure I read up on include guards. – Henry Gridley Feb 18 '16 at 18:33

"Error: Redefinition of Class" - But No Redeclaration

1 Answers1