Variable needs to be declared final

Question

I am trying to have a score variable go up by one every time a button is clicked. The problem is I must declare the score variable outside of the onClick otherwise it will always be set to 0. Also, I cannot declare the variable final because I am modifying the variable. Here is the code.

    int score = 0;

    View.OnClickListener listener = new View.OnClickListener() {
        @Override
        public void onClick(View v) {

            score++;

            scoreLabel.setText(String.valueOf(score));

Make it class member variable – Inducesmile Feb 19 '16 at 17:41 — Inducesmile, Feb 19 '16 at 17:41

Mathews Mathai · Answer 1 · 2016-02-19T18:21:59.483

2

The ideal solution would be to make the variable static and make it the member of the outer class. Making it static means, all the objects of the class will share a single copy of the variable and the value will remain same everywhere.

Declare static int score; in the outer class.

edited Feb 19 '16 at 18:21

answered Feb 19 '16 at 17:43

Mathews Mathai

1,707
13
31

score 1 · Answer 2 · answered Feb 19 '16 at 18:08

1

If you don't want to use static variables, you could declare the score in the outer class (private int score;), then initialize it in the constructor. This will give it the right scope to be accessed!

answered Feb 19 '16 at 18:08

slothdotpy

84
1
3

ΦXocę 웃 Пepeúpa ツ · Accepted Answer · 2016-02-19T17:41:21.923

0

The problem is that the var score is scoped in a method, move that and declare score as a class variable.

edited Feb 19 '16 at 17:41

answered Feb 19 '16 at 17:39

ΦXocę 웃 Пepeúpa ツ

47,427
17
69
97

Move the score variable as a "Global" variable or class variable.... – ΦXocę 웃 Пepeúpa ツ Feb 19 '16 at 17:42
Yes I know, but I can't do it unless I wait 10 minutes. – Zain Merchant Feb 19 '16 at 17:45
I just changed the score variable to be public. – Zain Merchant Feb 19 '16 at 17:46
Not the best idea. See Answer posted by @Mathews Mathai. – DSlomer64 Feb 19 '16 at 17:58

score 0 · Answer 4 · answered Feb 19 '16 at 18:38

0

You can use MutableInt which as its name indicates is a mutable integer. This class is provided in the apache commons. This way you can keep the variable local and final.

Hope this helps

answered Feb 19 '16 at 18:38

Youssef Lahoud

529
3
8

Variable needs to be declared final

4 Answers4