Checkbox value changes when scroll the listView

Question

I now that here I have some questions with the same topic, but any of this is working for me: When scrolling custom ListView, the checkbox value changes Checkbox gets unchecked when i scroll my custom listview

I can apply any of this answer to my code:

My problem is that if I check or uncheck some checkbox and scroll the listview, when I comeback to the item don't have his correct state.

Someone can I take a look to my getView method and try to see where is the error??

Thanks in advance.

This is my getView

@Override
public View getView(int position, View convertView, ViewGroup parent) {

    Log.e("ConvertView", String.valueOf(position));
    final ViewHolder holder;

    if (convertView == null) {
        LayoutInflater vi = (LayoutInflater)getSystemService( Context.LAYOUT_INFLATER_SERVICE);
        convertView = vi.inflate(R.layout.newspaper_list_row, null);

        holder = new ViewHolder();
        holder.newspaperName = (TextView) convertView.findViewById(R.id.newspaperName);
        holder.checkbox = (CheckBox) convertView.findViewById(R.id.checkBox1);

        Country country = countryList.get(position);
        holder.checkbox.setTag(country.getName());

        convertView.setTag(holder);

    } else {
        holder = (ViewHolder) convertView.getTag();
    }

    holder.checkbox.setOnClickListener(new View.OnClickListener() {
        public void onClick(View v) {

            CheckBox cb = (CheckBox) v;
            Country country = (Country) cb.getTag();


           if (((CheckBox) v).isChecked()) {
                holder.checkbox.setChecked(true);
                addPreferencesAndDataBase(country.getName(), country.getUrl());

            } else {
                removePreferencesAndDataBase(country.getName());
                holder.checkbox.setChecked(false);

            }
        }

    });

    Country country = countryList.get(position);
    holder.newspaperName.setText(country.getName());
    holder.checkbox.setChecked(country.isSelected());
    holder.checkbox.setTag(country);

    return convertView;

}

This is my country class:

public class Country {

    int id;
    String name = null;
    String url = null;
    boolean selected = false;

    public Country(String name, String url, boolean selected) {
        super();
        this.name = name;
        this.url = url;
        this.selected = selected;
    }

    public Country(String name, String url) {
        super();
        this.name = name;
        this.url = url;
    }

    public long getId() {
        return id;
    }

    public void setId(int id) {
        this.id = id;
    }


    public String getName() {
        return name;
    }
    public void setName(String name) {
        this.name = name;
    }

    public String getUrl() {
        return url;
    }
    public void setUrl(String url) {
        this.url = url;
    }

    public boolean isSelected() {
        return selected;
    }
    public void setSelected(boolean selected) {
        this.selected = selected;
    }

}

Answer 1

It looks like you're saving the state of the checkbox to shared preferences when it's clicked, but you're not updating the Country object to also reflect that change. If you update the new value of selected in your Country class with each click, it should be OK:

CheckBox cb = (CheckBox) v;
Country country = (Country) cb.getTag();
country.setSelected(cb.isChecked());  // add this line

Also you don't need to call setChecked() on the checkbox in your check listener. Checking the box will is enough to put the checkbox in the correct state.