why else part is not working in android?

Question

Even if login_id is null,the condition only executes if part.

 String login_id = "" ;

    if (login_id != null || login_id != "") {
                url = ONLINE + login_id;
            }else {
                url = direct_url;
            }

Hi, I think, you are checking null and black string then better option would be like. String login_id = "" ; if (!TextUtil.isEmpty(login_id)) { url = ONLINE + login_id; }else { url = direct_url; } Cheers..!! — Chinmay, Mar 02 '16 at 06:40

Salah Nour ElDin · Answer 1 · 2016-03-02T06:44:52.910

0

please try this :-

 String login_id = "" ;

    if (login_id != null || !login_id.equals("")) {
                url = ONLINE + login_id;
            }else {
                url = direct_url;
            }

becaues login_id != "" not working in case of string variable but !login_id.equal("") working correctly

edited Mar 02 '16 at 06:44

answered Mar 02 '16 at 06:34

Salah Nour ElDin

510
2
13

Personally, I think `isEmpty` makes for cleaner code – OneCricketeer Mar 02 '16 at 06:38
@Salah Nour ElDin:java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.lang.String.equals(java.lang.Object)' on a null object reference – Muhammed Riyas A V Mar 02 '16 at 06:38
please try to replace this operator || with && – Salah Nour ElDin Mar 02 '16 at 06:43

score 0 · Answer 2 · answered Mar 02 '16 at 06:35

0

just change login_id.equals("") or use

  if(!TextUtils.isEmpty(login_id)){

  }else{
  }

answered Mar 02 '16 at 06:35

Leonid Veremchuk

1,952
15
27

:Thanks man it helped me a lot.. – Muhammed Riyas A V Mar 02 '16 at 06:48

why else part is not working in android?

2 Answers2