get different values from the same asynctask class with different parameter android

Question

I'm trying to get different values from the same AsyncTask class but after executing the second line

bestsellerResult = new getProductsTask().execute("4");

the Two Arrays will have the same values.

public class Splash extends Activity {

    String bestsellerORoccassions;
    ArrayList<productDetails> categoryProductsData;
    ArrayList<productDetails> bestsellereData;
    ArrayList<productDetails> occassionsData;

    ArrayList<productDetails> bestsellerResult;
    ArrayList<productDetails> occassionResult;


    boolean internetConnection;
    private productAdapter productAdapter;
    GridView gridView;
    ArrayList<productDetails> productDetailsArr = new ArrayList<productDetails>();

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        setContentView(R.layout.activity_splash);

        bestsellerORoccassions = "";
        categoryProductsData = new ArrayList<>();
        bestsellereData = new ArrayList<>();
        occassionsData = new ArrayList<>();

        occassionResult = new ArrayList<>(); 
        bestsellerResult = new ArrayList<>();

        internetConnection = UtilityClass.isInternetAvailable(getApplicationContext());


        bestsellerORoccassions = "bestsellers";

        if (internetConnection) {

          occassionResult =  new getProductsTask().execute("41");
          bestsellerResult = new getProductsTask().execute("4");
        } else {
            Intent internet = new Intent(com.ecommerce.dell.ecommerce.Splash.this, NointernetConnection.class);
            startActivity(internet);
            finish();
        }
    }


    public class getProductsTask extends AsyncTask<String, Void, ArrayList<productDetails>> {


        JSONObject result = new JSONObject();
        JSONObject result1 = new JSONObject();
        String error = "";
        JsonFunctions jsonFunctions = new JsonFunctions();
        ArrayList<ArrayList<String>> return_products = new ArrayList<ArrayList<String>>();

        private ArrayList<productDetails> getProductsDataFromJSON(JSONObject productsJSONObj) throws JSONException {

            final String product_image = "image";
            final String product_name = "name";
            final String product_id = "id";
            final String productRealPrice = "price";
            final String getProductDiscount = "discount";
            final String getProductDescreiption = "description";
            final String getProductPercentage = "percentage";

            JSONArray productsArray = productsJSONObj.getJSONArray("products");

            for (int i = 0; i < productsArray.length(); i++) {
                /*get JSON Object represent product info(Image-Name-Real Price - Discount)*/
                JSONObject getProductInfo = productsArray.getJSONObject(i);
                String pImage = getProductInfo.getString(product_image);
                String pName = getProductInfo.getString(product_name);
                String pID = getProductInfo.getString(product_id);
                String pRealPrice = getProductInfo.getString(productRealPrice);
                String pDiscount = getProductInfo.getString(getProductDiscount);
                String pDescreiption = getProductInfo.getString(getProductDescreiption);
                String pPercentage = getProductInfo.getString(getProductPercentage);
                productDetailsArr.add(i, new productDetails(pName, pID, pRealPrice, pDiscount, pDescreiption, pImage, pPercentage));
            }
            Log.d("ProductDetails", "Product Details: ");
            for (int i = 0; i < productDetailsArr.size(); i++) {
                Log.d("ProductDetails", "Product Details: " + productDetailsArr.get(i).getProductID());
            }

            return productDetailsArr;
        }

        @Override
        protected void onPreExecute() {
            super.onPreExecute();
            //  progressDialog.show();
            Log.d("getProductsTask", "getProductsTask");
        }

        @Override
        protected ArrayList<productDetails> doInBackground(String... params) {
            result = jsonFunctions.getCategoryProducts(params[0], String.valueOf(0));


            if (result == null) {
                error = "null json object";
                return null;
            }
            try {
                if (result.getInt("success") == 1) {
                    return getProductsDataFromJSON(result);
                }
            } catch (Exception ex) {
                error = ex.toString();
                Log.d("getProductsTask", error);

            }
            return null;

        }

        @Override
        protected void onPostExecute(ArrayList<productDetails> products) {
            super.onPostExecute(products);




        }


    }


    @Override
    protected void onStop() {
        super.onStop();


    }
}

AsyncTask instances can only be used one time. refer http://stackoverflow.com/questions/6373826/execute-asynctask-several-times — sasikumar, Mar 07 '16 at 08:35
Are you saying that `occassionResult` changes value after the second task executes? — shmosel, Mar 07 '16 at 08:35
@shmosel yes after second task executes occassionResult values will be the same vallues of bestsellerResult — Mohamed Saber, Mar 07 '16 at 08:37
ok the values are the same after execution, but is the `occassionResult` really changing? — agi, Mar 07 '16 at 08:44
@agi yes, its values change after second task executes. in first execution occassionResult = {"1","2"} after second execution if bestsellerResult = {"4","5"} then occassionResult = {"4","5"} — Mohamed Saber, Mar 07 '16 at 08:47
asynctask runs in background thread. All the changes should be done in onPostExecute method — Anup Dasari, Mar 07 '16 at 08:49
@AnupDasari I did that and write all the changes in PostExecute method the same problem after second execution have the result in the Two Arrays — Mohamed Saber, Mar 07 '16 at 08:52

agi · Accepted Answer · 2016-03-07T09:40:02.970

Your AsyncTask changes and returns the productDetailsArr, which is always the same instance, because you declare it as a member of your Splash class and instantiate it there just once. So the occassionResult and the bestsellerResult are the same instances as the productDetailsArr.

To fix the problem just remove productDetailsArr from the Splash class and add ArrayList<productDetails> productDetailsArr = new ArrayList<productDetails>(); in the getProductsDataFromJSON() method.

This should work:

public class Splash extends Activity {

    String bestsellerORoccassions;
    ArrayList<productDetails> categoryProductsData;
    ArrayList<productDetails> bestsellereData;
    ArrayList<productDetails> occassionsData;

    ArrayList<productDetails> bestsellerResult;
    ArrayList<productDetails> occassionResult;


    boolean internetConnection;
    private productAdapter productAdapter;
    GridView gridView;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        setContentView(R.layout.activity_splash);

        bestsellerORoccassions = "";
        categoryProductsData = new ArrayList<>();
        bestsellereData = new ArrayList<>();
        occassionsData = new ArrayList<>();

        occassionResult = new ArrayList<>(); 
        bestsellerResult = new ArrayList<>();

        internetConnection = UtilityClass.isInternetAvailable(getApplicationContext());


        bestsellerORoccassions = "bestsellers";

        if (internetConnection) {

          occassionResult =  new getProductsTask().execute("41");
          bestsellerResult = new getProductsTask().execute("4");
        } else {
            Intent internet = new Intent(com.ecommerce.dell.ecommerce.Splash.this, NointernetConnection.class);
            startActivity(internet);
            finish();
        }
    }


    public class getProductsTask extends AsyncTask<String, Void, ArrayList<productDetails>> {


        JSONObject result = new JSONObject();
        JSONObject result1 = new JSONObject();
        String error = "";
        JsonFunctions jsonFunctions = new JsonFunctions();
        ArrayList<ArrayList<String>> return_products = new ArrayList<ArrayList<String>>();

        private ArrayList<productDetails> getProductsDataFromJSON(JSONObject productsJSONObj) throws JSONException {

            final String product_image = "image";
            final String product_name = "name";
            final String product_id = "id";
            final String productRealPrice = "price";
            final String getProductDiscount = "discount";
            final String getProductDescreiption = "description";
            final String getProductPercentage = "percentage";

            // *********  instantiate the list here  ***********
            ArrayList<productDetails> productDetailsArr = new ArrayList<productDetails>();
            JSONArray productsArray = productsJSONObj.getJSONArray("products");

            for (int i = 0; i < productsArray.length(); i++) {
                /*get JSON Object represent product info(Image-Name-Real Price - Discount)*/
                JSONObject getProductInfo = productsArray.getJSONObject(i);
                String pImage = getProductInfo.getString(product_image);
                String pName = getProductInfo.getString(product_name);
                String pID = getProductInfo.getString(product_id);
                String pRealPrice = getProductInfo.getString(productRealPrice);
                String pDiscount = getProductInfo.getString(getProductDiscount);
                String pDescreiption = getProductInfo.getString(getProductDescreiption);
                String pPercentage = getProductInfo.getString(getProductPercentage);
                productDetailsArr.add(i, new productDetails(pName, pID, pRealPrice, pDiscount, pDescreiption, pImage, pPercentage));
            }
            Log.d("ProductDetails", "Product Details: ");
            for (int i = 0; i < productDetailsArr.size(); i++) {
                Log.d("ProductDetails", "Product Details: " + productDetailsArr.get(i).getProductID());
            }

            return productDetailsArr;
        }

        @Override
        protected void onPreExecute() {
            super.onPreExecute();
            //  progressDialog.show();
            Log.d("getProductsTask", "getProductsTask");
        }

        @Override
        protected ArrayList<productDetails> doInBackground(String... params) {
            result = jsonFunctions.getCategoryProducts(params[0], String.valueOf(0));


            if (result == null) {
                error = "null json object";
                return null;
            }
            try {
                if (result.getInt("success") == 1) {
                    return getProductsDataFromJSON(result);
                }
            } catch (Exception ex) {
                error = ex.toString();
                Log.d("getProductsTask", error);

            }
            return null;

        }

        @Override
        protected void onPostExecute(ArrayList<productDetails> products) {
            super.onPostExecute(products);




        }


    }


    @Override
    protected void onStop() {
        super.onStop();


    }
}

i have error in that line occassionResult = new getProductsTask().execute("41"); — Mohamed Saber, Mar 07 '16 at 09:30
Did you changed the code the same way I did? What error did you get? — agi, Mar 07 '16 at 09:41

get different values from the same asynctask class with different parameter android

1 Answers1