ProgressDialog : Don't Dismissing after showing

Question

    private void copyFile(AppDB apkfile) {
    ProgressDialog pd=new ProgressDialog(this,ProgressDialog.STYLE_SPINNER);
    pd.show(this,"Coping ...",apkfile.name,true,true);
    File f1 = new File(apkfile.location);
    try {
        String fileName = apkfile.name;
        File f2 = new File(Environment.getExternalStorageDirectory().toString() + "/" + "Easy Share");
        f2.mkdirs();
        f2 = new File(f2.getPath() + "/" + fileName + ".apk");
        f2.createNewFile();
        InputStream in = new FileInputStream(f1);
        OutputStream out = new FileOutputStream(f2);
        byte[] buf = new byte[1024];
        int len;
        while ((len = in.read(buf)) > 0) {
            out.write(buf, 0, len);
        }
        in.close();
        out.close();
    } catch (FileNotFoundException ex) {
        Toast.makeText(this, ex.getMessage() + " in the specified directory.", Toast.LENGTH_SHORT);

    } catch (IOException e) {
        Toast.makeText(this, e.getMessage(), Toast.LENGTH_SHORT);
    }
    if(pd.isShowing()) {
   pd.dismiss();}

}

Hi everyone when trying to dismiss the progress dialog it wont do that and serarched for many solution but i not its same Problem. please help.

Update: there is Progress Dialog pd's class after running.

You can call `AlertDialog#dismiss` on the `AlertDialog` which is returned by `AlertDialog.Builder#create` — theapache64, Mar 08 '16 at 09:50
When i debug it i found that the pd is showing every thing null after showing. — Omar, Mar 08 '16 at 10:19
pd.show(this,"Coping ...",apkfile.name); use only this much instead pd.show(this,"Coping ...",apkfile.name,true,true); — Naveen Shriyan, Mar 08 '16 at 10:22
put a debug point for this line if(pd.isShowing()) , and check the control comes here or not , if it comes here then as u said pd = null after showing the dialog , it should hit with a NullPointerException...pls check and let meknow.. — Naveen Shriyan, Mar 08 '16 at 10:25
i did it before you say and add the image to post. and all its null what i suppose to do. — Omar, Mar 08 '16 at 10:30
http://stackoverflow.com/questions/17585759/cant-dismiss-progressdialog-after-the-asynctask-complete — Naveen Shriyan, Mar 08 '16 at 10:36
before u make any changes try making ProgressDialog "final", as below final ProgressDialog pd=new ProgressDialog(this,ProgressDialog.STYLE_SPINNER); — Naveen Shriyan, Mar 08 '16 at 10:38
final ProgressDialog pd=new ProgressDialog(this,ProgressDialog.STYLE_SPINNER); — Naveen Shriyan, Mar 08 '16 at 10:40

score 1 · Accepted Answer · answered Mar 08 '16 at 09:54

1

The copy should be done in a Thread or a AsyncTask. Show the dialog before executing the AsyncTask and hide in the onPOstExecute

protected void onPostExecute(Long result) {
       if(mProgressDialog.isShowing()) {
          mProgressDialog.dismiss();}
       }  
}

answered Mar 08 '16 at 09:54

Damien Praca

3,126
21
14

Thanks Man i finally solved it With AsyncTask. I used this Tutorial http://stackoverflow.com/questions/25647881/android-asynctask-example-and-explanation – Omar Mar 09 '16 at 10:39

score 0 · Answer 2 · answered Mar 08 '16 at 09:49

Try with finally

private void copyFile(AppDB apkfile) {
    ProgressDialog pd=new ProgressDialog(this,ProgressDialog.STYLE_SPINNER);
    pd.show(this,"Coping ...",apkfile.name,true,true);
    File f1 = new File(apkfile.location);
    try {
        String fileName = apkfile.name;
        File f2 = new File(Environment.getExternalStorageDirectory().toString() + "/" + "Easy Share");
        f2.mkdirs();
        f2 = new File(f2.getPath() + "/" + fileName + ".apk");
        f2.createNewFile();
        InputStream in = new FileInputStream(f1);
        OutputStream out = new FileOutputStream(f2);
        byte[] buf = new byte[1024];
        int len;
        while ((len = in.read(buf)) > 0) {
            out.write(buf, 0, len);
        }
        in.close();
        out.close();
    } catch (FileNotFoundException ex) {
        Toast.makeText(this, ex.getMessage() + " in the specified directory.", Toast.LENGTH_SHORT);

    } catch (IOException e) {
        Toast.makeText(this, e.getMessage(), Toast.LENGTH_SHORT);
    } finally {
      if(pd.isShowing()) {
        pd.dismiss();
      }
    }
}

score 0 · Answer 3 · answered Mar 08 '16 at 10:02

it is working well i will tell you two possibilities

please use it in try block at last as

try {
    String fileName = apkfile.name;
    File f2 = new File(Environment.getExternalStorageDirectory().toString() + "/" + "Easy Share");
    f2.mkdirs();
    f2 = new File(f2.getPath() + "/" + fileName + ".apk");
    f2.createNewFile();
    InputStream in = new FileInputStream(f1);
    OutputStream out = new FileOutputStream(f2);
    byte[] buf = new byte[1024];
    int len;
    while ((len = in.read(buf)) > 0) {
        out.write(buf, 0, len);
    }
    in.close();
    out.close();
   if(pd.isShowing()) {
   pd.dismiss();}
    } catch (FileNotFoundException ex) {
        Toast.makeText(this, ex.getMessage() + " in the specified directory.", Toast.LENGTH_SHORT);
   } catch (IOException e) {
    Toast.makeText(this, e.getMessage(), Toast.LENGTH_SHORT);
}

}

second is use in delay

ProgressDialog : Don't Dismissing after showing

3 Answers3