Python - For loop problems

Question

I am trying to create a loop to go through ~3,000 .xml files to search for certain lines and print out into one txt file.

My original code which i am able to use on one xml is:

my_file = open(r'C:\temp\20160309_test_xml\out.txt', 'w')

with open(r'C:\temp\20160309_test_xml\test.xml', 'r') as file:
    for name, lines in enumerate(file, 1):
        if "OBJNAM" in lines:
            my_file.write(file.next())
with open(r'C:\temp\20160309_test_xml\test.xml', 'r') as file:
    for number,  line in enumerate(file, 1):
        if "srfres" in line:
            my_file.write(file.next())
file.close()

I've attempted to create a loop for this but the output txt is printing blank:

import glob
import os

path = r'C:\temp\test_xml'
xml_directory = os.path.join(path, '*.xml')
xml_list = glob.glob(xml_directory)
my_file = open(r'C:\temp\20160309_test_xml\out.txt', 'w')

for xml in xml_list:
    for name, lines in enumerate(xml, 1):
        if "OBJNAM" in lines:
            my_file.write(file.next())
for xml in xml_list:
    for number,  line in enumerate(xml, 1):
        if "srfres" in line:
            my_file.write(xml.next())

my_file.close()
print

What is .next() and why you use it? Should not you use the "lines" var? — Alexander Trakhimenok, Mar 11 '16 at 16:37
i am using .next() to pull out a line below the word i am searching for as each text file has the same word in but not on the same line each time eg. i am searching OBJNAME to pull out the attribute name (Value): `` `2014 HI1447 Blakeney Overfalls 1m CUBE` (separate lines) — Alice Palmer, Mar 11 '16 at 16:42
Might be relevant: http://stackoverflow.com/q/13613336/198633 — inspectorG4dget, Mar 11 '16 at 16:49

score 0 · Answer 1 · answered Mar 11 '16 at 16:39

my_files = os.listdir("/all_files/") #put your input directory here
my_writer = open(r'C:\temp\20160309_test_xml\out.txt', 'w')
for fn in my_files:
    if not fn.endswith(".xml"):
         continue
    with open(fn, 'r') as f: #open and read from every xml file
         for line in f:
             if "OBJNAM" in line or "srfres" in line:
                  my_writer.write(line)
my_writer.close()

score 0 · Answer 2 · answered Mar 11 '16 at 16:40

0

Or maybe you can try with list comprehension

[(name,lines) for name,lines in enumerate(xml_list)]

answered Mar 11 '16 at 16:40

Richard Rublev

7,718
16
77
121

score 0 · Answer 3 · answered Mar 11 '16 at 16:43

It looks like you're not opening files in your loop and instead you're iterating over paths.

I have few suggestions regarding your code:

You can iterate over file lines like that:

with open(path, 'r') as file:
    for line in file:
        print line

Also, when dealing with xml files, maybe you could use xml lib.

score 0 · Answer 4 · answered Mar 11 '16 at 16:49

import glob
import os

xmlDir = r'C:\temp\test_xml'
xmlFiles = glob.glob(os.path.join(xmlDir, "*.xml"))
outfilepath = r'C:\temp\20160309_test_xml\out.txt'
keywords = ['OBJNAM', 'srfres']

copy = False
with open(outfilepath, 'w') as outfile:
    for fpath in xmlFiles:
        with open(fpath) as infile:
            for line in infile:
                if copy: outfile.write(line)

                if any (w in line for w in keywords):
                    copy = True
                    continue
                else:
                    copy = False
                    continue

Python - For loop problems

4 Answers4